Date: Thu, 17 Mar 2011 17:51:04 -0400
From: Dave Jones <davej@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: make checkpatch warn about memset with swapped arguments.
Message-ID: <20110317215104.GA12157@redhat.com>
Mail-Followup-To: Dave Jones <davej@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
References: <20110317045209.GA18656@redhat.com>
 <20110317193645.GD14675@home.goodmis.org>
 <20110317200215.GA4084@redhat.com>
 <1300394224.16880.518.camel@gandalf.stny.rr.com>
 <20110317141108.52697d81.akpm@linux-foundation.org>
 <1300397896.16880.584.camel@gandalf.stny.rr.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1300397896.16880.584.camel@gandalf.stny.rr.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 836
Lines: 22

On Thu, Mar 17, 2011 at 05:38:16PM -0400, Steven Rostedt wrote:

 > > Maybe it's just me, but I think it would be better to use bzero() for
 > > this operation - it's more readable and it can't be screwed up.  Then
 > > checkpatch checks for memset(xxx, 0, xxx) and for memset(xxx, xxx, 0)
 > > and says "hey, use bzero".  
 > 
 > Honestly, I've never had the issues with memset. Maybe back in college.
 > But heh, whatever.

You're smarter than the average bear.

Given how often this bug turns up in both userspace and kernelspace,
it's a landmine waiting for someone to step on.

	Dave
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/