Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756186Ab1CRMj3 (ORCPT ); Fri, 18 Mar 2011 08:39:29 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:57036 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800Ab1CRMjW (ORCPT ); Fri, 18 Mar 2011 08:39:22 -0400 Date: Fri, 18 Mar 2011 12:39:17 +0000 From: Mark Brown To: "Nori, Sekhar" Cc: Subhasish Ghosh , "davinci-linux-open-source@linux.davincidsp.com" , "Watkins, Melissa" , open list , Samuel Ortiz , "linux-arm-kernel@lists.infradead.org" , "sachi@mistralsolutions.com" Subject: Re: [PATCH v3 1/7] mfd: add pruss mfd driver. Message-ID: <20110318123917.GC27129@sirena.org.uk> References: <1299592667-21367-1-git-send-email-subhasish@mistralsolutions.com> <1299592667-21367-2-git-send-email-subhasish@mistralsolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: How do I get HOME? User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Scanned: No (on cassiel.sirena.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 22 On Fri, Mar 18, 2011 at 05:29:39PM +0530, Nori, Sekhar wrote: > PRUSS as an IP is not really tied to the DA8xx SoC architecture. > So, can you please name the files ti-pruss* or even just pruss if > MFD folks are okay with it? This... > > +EXPORT_SYMBOL(pruss_get_clk_freq); > This looks strange. Why do we need this? There > is clk_get_rate() API in the kernel would would > seem more suitable. ...unfortunately conflicts with this - currently all clock API implementations are unique to the platform and there's no way of adding clocks that works over multiple platforms. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/