Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756716Ab1CRSrA (ORCPT ); Fri, 18 Mar 2011 14:47:00 -0400 Received: from toast.topped-with-meat.com ([168.75.111.31]:40841 "EHLO topped-with-meat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755674Ab1CRSqx (ORCPT ); Fri, 18 Mar 2011 14:46:53 -0400 X-Greylist: delayed 620 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Mar 2011 14:46:53 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Srikar Dronamraju X-Fcc: ~/Mail/lkml Cc: Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Andi Kleen , Christoph Hellwig , Masami Hiramatsu , Oleg Nesterov , Andrew Morton , SystemTap , Jim Keniston , Ananth N Mavinakayanahalli , LKML , "Paul E. McKenney" Subject: Re: [PATCH v2 2.6.38-rc8-tip 6/20] 6: x86: analyze instruction and determine fixups. In-Reply-To: Srikar Dronamraju's message of Friday, 18 March 2011 23:54:57 +0530 <20110318182457.GA24048@linux.vnet.ibm.com> References: <20110314133403.27435.7901.sendpatchset@localhost6.localdomain6> <20110314133507.27435.71382.sendpatchset@localhost6.localdomain6> <20110318182457.GA24048@linux.vnet.ibm.com> X-Windows: the joke that kills. Message-Id: <20110318183629.2AB052C286@topped-with-meat.com> Date: Fri, 18 Mar 2011 11:36:29 -0700 (PDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.0 cv=K6VZ71qI c=1 sm=1 a=WaHTwlwe2vUA:10 a=kj9zAlcOel0A:10 a=HmEWQsaWwob7zDLwClAA:9 a=1A_kdLFkw_G9ZIfHBwAA:7 a=vMOMKWXsHKddFGYuQVTn8bsjAaQA:4 a=CjuIK1q_8ugA:10 a=j4CujHGUVanNbcFM:21 a=slv4dBQuIyfjkoTa:21 a=WkljmVdYkabdwxfqvArNOQ==:117 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 20 > handle_riprel_insn() returns 0 if the instruction is not rip-relative > returns 1 if its rip-relative but can use XOL slots. > returns -1 if its rip-relative but cannot use XOL. > > We dont see any instructions that are rip-relative and cannot use XOL. > so the check and return are redundant and I will remove that in the next > patch. How is that? You can only adjust a rip-relative instruction correctly if the instruction copy is within 2GB of the original target address, which cannot be presumed to always be the case in user address space layout (unlike the kernel). Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/