Date: Fri, 18 Mar 2011 12:57:24 -0700 (PDT)
Message-Id: <20110318.125724.258093097.davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: ahiliation@yahoo.co.in, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: patch for format issues and header bug in net/ipv4/icmp.c
From: David Miller <davem@davemloft.net>
In-Reply-To: <1300477261.2589.28.camel@bwh-desktop>
References: <20110318183529.GA3617@debian.Jeff>
	<1300477261.2589.28.camel@bwh-desktop>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 729
Lines: 19

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 18 Mar 2011 19:41:01 +0000

> On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
>> hello ,
>> 
>> I have created a patch for net/ipv4/icmp.c
>> using checkpatch.pl script to fix several warnings
>> and an error.
> 
> You need to learn C programming before trying to correct C programs.
> You should not just do what it takes to make checkpatch.pl happy.

I completely agree, and I absolutely refuse to apply this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/