Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757639Ab1CRX2e (ORCPT ); Fri, 18 Mar 2011 19:28:34 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36348 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757585Ab1CRX22 (ORCPT ); Fri, 18 Mar 2011 19:28:28 -0400 Date: Fri, 18 Mar 2011 16:28:26 -0700 From: Andrew Morton To: Mike Frysinger Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] headers: use __aligned_xx types for userspace Message-Id: <20110318162826.5295f130.akpm@linux-foundation.org> In-Reply-To: <1300474237-10980-1-git-send-email-vapier@gentoo.org> References: <1300474237-10980-1-git-send-email-vapier@gentoo.org> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1821 Lines: 43 On Fri, 18 Mar 2011 14:50:37 -0400 Mike Frysinger wrote: > Now that we finally have __aligned_xx exported to userspace, convert > the headers that get exported over to the proper type. > Sob. Please don't assume that because you're on top of an issue, all the rest of us are. A bit of git-log grovelling turns up : commit 79b5dc0c64d88cda3da23b2e22a5cec0964372ac : Author: Eric Paris : Date: Fri Oct 15 14:34:14 2010 -0700 : types.h: define __aligned_u64 and expose to userspace : : We currently have a kernel internal type called aligned_u64 which aligns : __u64's on 8 bytes boundaries even on systems which would normally align : them on 4 byte boundaries. This patch creates a new type __aligned_u64 : which does the same thing but which is exposed to userspace rather than : being kernel internal. but that really doesn't tell us why it was merged either. Perhaps that came out in the followup discussion and I failed to fix the changelog. Still, it doesn't hurt to educate people. Please explain why we are making this change? > include/linux/if_ppp.h | 16 ++++++++-------- > include/linux/netfilter/nfnetlink_log.h | 4 ++-- > include/linux/netfilter/nfnetlink_queue.h | 4 ++-- > include/linux/netfilter/xt_connbytes.h | 4 ++-- > include/linux/netfilter/xt_quota.h | 2 +- > 5 files changed, 15 insertions(+), 15 deletions(-) davem stuff :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/