Date: Sat, 19 Mar 2011 10:15:44 +0100
From: Wolfram Sang <w.sang@pengutronix.de>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        vmehta@atheros.com, naveen.singh@atheros.com, kvalo@adurom.com,
        j@w1.fi
Subject: Re: [RFC 0/4] sdhci: few patches for ENE 712 support
Message-ID: <20110319091544.GA16635@pengutronix.de>
References: <1300486320-23607-1-git-send-email-lrodriguez@atheros.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt"
Content-Disposition: inline
In-Reply-To: <1300486320-23607-1-git-send-email-lrodriguez@atheros.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1897
Lines: 57


--pf9I7BMVVzbSWLtt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> I prefer code upstream though so here is my split and cleanup
> of these patches. I've tested it with my ENE card. Since I am
> new to SDHCI I would prefer someone with more experience review
> these chagnes and the respective commit log messages. I've
> tried to make sense of them as best as I can. Unfortunately
> I was not given any explanation to these changes except the
> patch I got so I tried to make the best of it.

You did make the best out of it; still, you probably won't be surprised to =
hear
that all the patches are, well, not acceptable ;) I agree with Chris about =
1/4,
I think 2-4 are for a broken card detection and there is already a quirk for
that. So you could also try dropping 2-4 and use

	sdhci.debug_quirks =3D 0x8028

That should enable the standard quirks for this card and BROKEN_CARD. Can y=
ou
alsso please post the PCI-ID of this card? And does it make a difference if=
 you
use the SDIO-WLAN card or a standard SD memory card?

Regards,

   Wolfram

--=20
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

--pf9I7BMVVzbSWLtt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAk2EdEAACgkQD27XaX1/VRtHfACbBYbyJo3hH4A7IJptE5WI0Aoe
jbIAnRw0Zx5yA1SJWQLpw4WgM4fYcpsw
=Ilvb
-----END PGP SIGNATURE-----

--pf9I7BMVVzbSWLtt--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/