Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756925Ab1CSRDt (ORCPT ); Sat, 19 Mar 2011 13:03:49 -0400 Received: from 4.27.mail-out.ovh.net ([46.105.52.239]:52569 "HELO 27.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1755416Ab1CSRDq (ORCPT ); Sat, 19 Mar 2011 13:03:46 -0400 Message-ID: <4D84E1E6.1030405@example.com> Date: Sat, 19 Mar 2011 18:03:34 +0100 From: Piotr Hosowicz Reply-To: piotr@hosowicz.com Organization: hosowicz.com User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110307 Icedove/3.0.11 MIME-Version: 1.0 To: Anca Emanuel CC: Eric Dumazet , Oliver Neukum , LKML , netdev@vger.kernel.org, Francois Romieu , David Miller Subject: Re: [PATCH] r8169: fix a bug in rtl8169_init_phy() References: <4D84A46B.1000407@example.com> <1300547930.2831.27.camel@edumazet-laptop> <201103191631.07952.oliver@neukum.org> <1300548821.2831.28.camel@edumazet-laptop> <1300549151.2831.32.camel@edumazet-laptop> <4D84D098.1050802@example.com> <1300550653.2831.34.camel@edumazet-laptop> <4D84D956.8090407@example.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 16278260854702240256 X-Ovh-Remote: 178.36.62.164 (178-36-62-164.adsl.inetia.pl) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-Spam-Check: DONE|U 0.5/N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 39 On 19.03.2011 17:38, Anca Emanuel wrote: > On Sat, Mar 19, 2011 at 6:27 PM, Piotr Hosowicz wrote: >> On 19.03.2011 17:04, Eric Dumazet wrote: >>> >>> Le samedi 19 mars 2011 à 16:49 +0100, Piotr Hosowicz a écrit : >>> >>>> I do not understand. I reverted the commit you mentioned and am building >>>> now. Will it suffice? >>>> >>> >>> Either you >>> >>> 1) Revert the commit >> >> OK. This is what I've done and everything is OK, net works as usual. But >> what should I do next? Will the revert be done on the GIT server? And when? >> I try not to clone to much and wastefuly. And am new to GIT so sorry for the >> question. > > Next: Test Eric's patch, and send and email with Tested-by tag. I just built the kernel with the commit reverted as Eric said in the beginning and it works. Should I build again with patching in place of reverting and report it? Is the method same as ordinary patching? Regards, Piotr Hosowicz -- Sygnaturka utworzona wyłącznie ze zrecyklingowanych literek najwyższej jakości poddanych procesowi starannej selekcji. NP: Big Big Train - The Underfall Yard NB: 2.6.38-20110319-1638-net+ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/