Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231Ab1CTTIj (ORCPT ); Sun, 20 Mar 2011 15:08:39 -0400 Received: from www.tglx.de ([62.245.132.106]:37234 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564Ab1CTTIi (ORCPT ); Sun, 20 Mar 2011 15:08:38 -0400 Date: Sun, 20 Mar 2011 20:08:10 +0100 (CET) From: Thomas Gleixner To: David Ahern cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, acme@ghostprotocols.net, mingo@elte.hu, peterz@infradead.org, fweisbec@gmail.com, paulus@samba.org Subject: Re: [PATCH 1/5] perf events: add support for realtime clock attribute In-Reply-To: <1300647277-8431-2-git-send-email-daahern@cisco.com> Message-ID: References: <1300647277-8431-1-git-send-email-daahern@cisco.com> <1300647277-8431-2-git-send-email-daahern@cisco.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 17 On Sun, 20 Mar 2011, David Ahern wrote: > + > + if (sample_type & PERF_SAMPLE_REALTIME) > + data->realtime = ktime_to_ns(ktime_get_real()); That's going to live lock on any sample which happens to hit in a xtime_lock write locked section. I knew why I suggested adding tracepoints to the timekeeping code :) Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/