Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825Ab1CUFWz (ORCPT ); Mon, 21 Mar 2011 01:22:55 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:58700 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659Ab1CUFWw convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2011 01:22:52 -0400 From: "Janorkar, Mayuresh" To: Carl Vanderlip , David Brown , Daniel Walker , Bryan Huntsman CC: Brian Swetland , Dima Zavin , Rebecca Schultz Zavin , Colin Cross , "linux-fbdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Mon, 21 Mar 2011 10:52:37 +0530 Subject: RE: [PATCH 15/20] video: msm: convert printk to pr_* Thread-Topic: [PATCH 15/20] video: msm: convert printk to pr_* Thread-Index: AcvlvTALkrKZYtYqRXeKzt5EyxPAbQByp3MQ Message-ID: References: <1300484846-26393-1-git-send-email-carlv@codeaurora.org> <1300485552-27519-1-git-send-email-carlv@codeaurora.org> In-Reply-To: <1300485552-27519-1-git-send-email-carlv@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2863 Lines: 81 > -----Original Message----- > From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev- > owner@vger.kernel.org] On Behalf Of Carl Vanderlip > Sent: Saturday, March 19, 2011 3:29 AM > To: David Brown; Daniel Walker; Bryan Huntsman > Cc: Brian Swetland; Dima Zavin; Rebecca Schultz Zavin; Colin Cross; linux- > fbdev@vger.kernel.org; Carl Vanderlip; linux-arm- > kernel@lists.infradead.org; linux-arm-msm@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH 15/20] video: msm: convert printk to pr_* > > Reword debugging messages to use pr_err and pr_warning > > Authors: > Dima Zavin > Rebecca Schultz Zavin > Colin Cross > > Signed-off-by: Carl Vanderlip > --- > drivers/video/msm/mdp.c | 11 ++++------- > 1 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c > index 8184ca9..b03204d 100644 > --- a/drivers/video/msm/mdp.c > +++ b/drivers/video/msm/mdp.c > @@ -42,16 +42,13 @@ DEFINE_MUTEX(mdp_mutex); > > static int locked_enable_mdp_irq(struct mdp_info *mdp, uint32_t mask) > { > - int ret = 0; > - > BUG_ON(!mask); > > /* if the mask bits are already set return an error, this interrupt > * is already enabled */ > if (mdp_irq_mask & mask) { > - printk(KERN_ERR "mdp irq already on already on %x %x\n", > - mdp_irq_mask, mask); > - ret = -1; > + pr_err("mdp irq already on %x %x\n", mdp_irq_mask, mask); > + return -1; Please use standard error codes. http://lxr.linux.no/#linux+v2.6.38/include/asm-generic/errno-base.h The code would be more readable. Plus it would help in debugging. > } > /* if the mdp irq is not already enabled enable it */ > if (!mdp_irq_mask) { > @@ -172,9 +169,9 @@ static int mdp_wait(struct mdp_info *mdp, uint32_t > mask, wait_queue_head_t *wq) > > spin_lock_irqsave(&mdp->lock, irq_flags); > if (mdp_irq_mask & mask) { > + pr_warning("%s: timeout waiting for mdp to complete 0x%x\n", > + __func__, mask); > locked_disable_mdp_irq(mdp, mask); > - printk(KERN_WARNING "timeout waiting for mdp to complete > %x\n", > - mask); > ret = -ETIMEDOUT; > } > spin_unlock_irqrestore(&mdp->lock, irq_flags); > -- > Sent by an employee of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/