Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701Ab1CUWHa (ORCPT ); Mon, 21 Mar 2011 18:07:30 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57566 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754567Ab1CUWH2 (ORCPT ); Mon, 21 Mar 2011 18:07:28 -0400 Date: Mon, 21 Mar 2011 15:06:22 -0700 From: Andrew Morton To: Miklos Szeredi Cc: Minchan Kim , linux-mm , LKML , Rik van Riel , KAMEZAWA Hiroyuki , Mel Gorman Subject: Re: [PATCH] mm: optimize replace_page_cache_page Message-Id: <20110321150622.4b5b088e.akpm@linux-foundation.org> In-Reply-To: <1298545015.5637.7.camel@tucsk.pomaz.szeredi.hu> References: <1297355626-5152-1-git-send-email-minchan.kim@gmail.com> <20110219234121.GA2546@barrios-desktop> <20110223144445.86d0ca2b.akpm@linux-foundation.org> <1298545015.5637.7.camel@tucsk.pomaz.szeredi.hu> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2196 Lines: 64 On Thu, 24 Feb 2011 11:56:55 +0100 Miklos Szeredi wrote: > On Thu, 2011-02-24 at 08:37 +0900, Minchan Kim wrote: > > On Thu, Feb 24, 2011 at 7:44 AM, Andrew Morton > > wrote: > > > On Sun, 20 Feb 2011 08:41:21 +0900 > > > Minchan Kim wrote: > > > > > >> Resend. > > > > > > Reignore. > > > > > >> he patch is based on mmotm-2011-02-04 + > > >> mm-add-replace_page_cache_page-function-add-freepage-hook.patch. > > >> > > >> On Fri, Feb 11, 2011 at 01:33:46AM +0900, Minchan Kim wrote: > > >> > This patch optmizes replace_page_cache_page. > > >> > > > >> > 1) remove radix_tree_preload > > >> > 2) single radix_tree_lookup_slot and replace radix tree slot > > >> > 3) page accounting optimization if both pages are in same zone. > > >> > > > >> > Cc: Miklos Szeredi > > >> > Cc: Rik van Riel > > >> > Cc: KAMEZAWA Hiroyuki > > >> > Cc: Mel Gorman > > >> > Signed-off-by: Minchan Kim > > >> > --- > > >> > mm/filemap.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++--------- > > >> > 1 files changed, 51 insertions(+), 10 deletions(-) > > >> > > > >> > Hi Miklos, > > >> > This patch is totally not tested. > > >> > Could you test this patch? > > > > > > ^^^ Because of this. > > > > > > Is it tested yet? > > > > > > > Miklos. Could you test this? > > If you are busy, let me know how to test it. I will. > > Thanks. > > Grab git version of libfuse and do something like this: > > fuse/example/fusexmp_fh -obig_writes /mnt/fuse/ > dd if=/tmp/random0 of=/mnt/fuse/tmp/random1 bs=1M > md5sum /tmp/radom0 /tmp/random1 > > This should exercise the page moving. > > I'll review and test the patch when I have some time. > Too late. It took months to half-finish Miklos's patch and now I'm sitting on other patches which depend on it, so it's going in. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/