Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932124Ab1CVCoe (ORCPT ); Mon, 21 Mar 2011 22:44:34 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:35390 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754558Ab1CVCoc convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2011 22:44:32 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=WaWYOvQqwm9EWEwaum4JK6OYGb11/EwHKogiZWuJN/gjMNrBNeCe66vQbBbtf90Kvo HkNYdBH2iCRbxNxucM/0LA9kkMrdGxC1SWbzDWvb7jNnj+XS0YckkAp6LWzD8Haxm8cF tiLGUR6CM0x6rmu+QBaSVACsHe940HO9zVJP8= MIME-Version: 1.0 In-Reply-To: References: <1300098516-1601-1-git-send-email-ratbert.chuang@gmail.com> <1300169637-1628-1-git-send-email-ratbert.chuang@gmail.com> From: Po-Yu Chuang Date: Tue, 22 Mar 2011 10:40:23 +0800 Message-ID: Subject: Re: [PATCH v2] arm: cmpxchg syscall should data abort if page not write To: Nicolas Pitre Cc: Ashwin Chaugule , Russell King - ARM Linux , Po-Yu Chuang , tony@atomide.com, lkml , joe@perches.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1406 Lines: 31 Dear Nicolas Pitre, On Tue, Mar 22, 2011 at 4:41 AM, Nicolas Pitre wrote: > On Fri, 18 Mar 2011, Po-Yu Chuang wrote: >> On Fri, Mar 18, 2011 at 1:57 AM, Nicolas Pitre wrote: >> > Nope.  The code being fixed here was suptly broken so it needs fixing. >> > However this code is almost never used, if at all, as it is a fall-back >> > solution for when all the better alternatives are not available for some >> > reasons (and I'm still wondering what those reasons are for Po-Yu Chuang >> > to actually use that code).  In practice this bug should have affected >> > no one. >> >> We met this problem while porting an v5 SMP processor because kernel >> selects NEEDS_SYSCALL_FOR_CMPXCHG by default if CPU_32v5. >> >> After we added our own implementation of __kuser_cmpxchg, this code >> is not needed anymore. But since this is actually a bug, it is still a good >> idea to submit a patch. :-) > > Yes.  Please send to RMK's patch system with my ACK. I thought that Russell King would apply this patch after you ACKed it. Doesn't it work like this here? How should I do next? Best regards, Po-Yu Chuang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/