DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=mMBiMy3B9H0yv3b0x8TqSAQ1ojWYzwJFwnjNGh/gq5MTjoxUhu/AfmIm5CGXj7m5uW
         3wz6bUam0agsYefm80jUpjF0NvO6iQpf0aSKvLCher5czSBpUyUW8399e2hZ1awS0MNO
         YjhX4yuXXDtyINdLhNDKru5I47V1AjOaKaXq0=
Date: Mon, 21 Mar 2011 23:19:58 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: tsc2005: fix locking issue
Message-ID: <20110322061958.GA7990@core.coreip.homeip.net>
References: <1300724650-6641-1-git-send-email-aaro.koskinen@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1300724650-6641-1-git-send-email-aaro.koskinen@nokia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1108
Lines: 26

On Mon, Mar 21, 2011 at 06:24:10PM +0200, Aaro Koskinen wrote:
> Commit 0b950d3 (Input: tsc2005 - add open/close) introduced a
> locking issue with the ESD watchdog: __tsc2005_disable() is calling
> cancel_delayed_work_sync() with mutex held, and the work also needs the
> same mutex.
> 
> Fix the problem by using cancel_delayed_work() on disable. If
> the ESD work was running it will check if the device is closed
> or suspended, and in that case it will do nothing and skip
> re-arming. cancel_delayed_work_sync() is still needed when the module
> is removed.

Hmm, indeed. However, instead of moving cancel_delayed_work_sync() to
remove maybe we should use mutex_trylock() in tsc2005_esd_work()?
If trylock fails that means that device is in the middle of open/close
transition. We should just reschedule the work and get out of there.
 
Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/