Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158Ab1CVH4g (ORCPT ); Tue, 22 Mar 2011 03:56:36 -0400 Received: from mtagate7.uk.ibm.com ([194.196.100.167]:47364 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048Ab1CVH4c (ORCPT ); Tue, 22 Mar 2011 03:56:32 -0400 Date: Tue, 22 Mar 2011 08:56:24 +0100 From: Martin Schwidefsky To: Prasad Joshi Cc: heiko.carstens@de.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, mitra@kqinfotech.com Subject: Re: [RFC][PATCH v3 09/22] mm, s390: add gfp flags variant of pud, pte, and pte allocations Message-ID: <20110322085624.6a7efecf@mschwide.boeblingen.de.ibm.com> In-Reply-To: <20110321190239.GA6541@prasad-kvm> References: <20110318194341.GB4746@prasad-kvm> <20110318194600.GC4746@prasad-kvm> <20110318194740.GD4746@prasad-kvm> <20110318194929.GE4746@prasad-kvm> <20110318195035.GF4746@prasad-kvm> <20110318195141.GG4746@prasad-kvm> <20110318195307.GH4746@prasad-kvm> <20110318195507.GI4746@prasad-kvm> <20110318195643.GJ4746@prasad-kvm> <20110321093412.2776a69f@mschwide.boeblingen.de.ibm.com> <20110321190239.GA6541@prasad-kvm> Organization: IBM Corporation X-Mailer: Claws Mail 3.7.8 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 41 On Mon, 21 Mar 2011 19:02:39 +0000 Prasad Joshi wrote: > On Mon, Mar 21, 2011 at 09:34:12AM +0100, Martin Schwidefsky wrote: > > On Fri, 18 Mar 2011 19:56:44 +0000 > > Prasad Joshi wrote: > > > > > - Added function __crst_table_alloc() which is similar to crst_table_alloc() > > > but accepts an extra argument gfp_t. The function uses given allocation > > > flag to allocate pages. > > > > > > - Added a function __page_table_alloc() to allocate page table entries. This > > > function is allows caller to specify the page allocation flag. The > > > allocation flag is then passed to alloc_page(). The rest of the function is > > > copy of the original page_table_alloc(). > > > > The approach of this patch series seems straightforward, the only nitpick I > > have is the fact that two new functions __crst_table_alloc/__page_table_alloc > > are introduced. There aren't many call sites for the two original functions, > > namely 4 for crst_table_alloc and 3 for page_table_alloc. Why not add the > > gfp flag GFP_KERNEL to these call sites? Then the two additional functions > > would not be needed. > > Thanks a lot Martin for your reply. Here is a new patch, which the changes > you suggested. Looks good now. For the s390 architecture part: Acked-by: Martin Schwidefsky -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/