Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753508Ab1CVJf3 (ORCPT ); Tue, 22 Mar 2011 05:35:29 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:41489 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877Ab1CVJf1 convert rfc822-to-8bit (ORCPT ); Tue, 22 Mar 2011 05:35:27 -0400 From: "Nori, Sekhar" To: Mark Brown CC: Subhasish Ghosh , "davinci-linux-open-source@linux.davincidsp.com" , "Watkins, Melissa" , open list , Samuel Ortiz , "linux-arm-kernel@lists.infradead.org" , "sachi@mistralsolutions.com" Date: Tue, 22 Mar 2011 15:05:07 +0530 Subject: RE: [PATCH v3 1/7] mfd: add pruss mfd driver. Thread-Topic: [PATCH v3 1/7] mfd: add pruss mfd driver. Thread-Index: AcvlaYI3wUiX7dfGRFiMdHbMtqNo/ADBPeBA Message-ID: References: <1299592667-21367-1-git-send-email-subhasish@mistralsolutions.com> <1299592667-21367-2-git-send-email-subhasish@mistralsolutions.com> <20110318123917.GC27129@sirena.org.uk> In-Reply-To: <20110318123917.GC27129@sirena.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 34 Hi Mark, On Fri, Mar 18, 2011 at 18:09:17, Mark Brown wrote: > On Fri, Mar 18, 2011 at 05:29:39PM +0530, Nori, Sekhar wrote: > > > PRUSS as an IP is not really tied to the DA8xx SoC architecture. > > So, can you please name the files ti-pruss* or even just pruss if > > MFD folks are okay with it? > > This... > > > > +EXPORT_SYMBOL(pruss_get_clk_freq); > > > This looks strange. Why do we need this? There > > is clk_get_rate() API in the kernel would would > > seem more suitable. > > ...unfortunately conflicts with this - currently all clock API > implementations are unique to the platform and there's no way of adding > clocks that works over multiple platforms. Hmm, I guess I have a limited view of this. We do have drivers which use clock API and work across OMAP and DaVinci series of ARM SoCs. The clock implementation in this case is under mach-omap and mach-davinci respectively. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/