Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755412Ab1CVLo0 (ORCPT ); Tue, 22 Mar 2011 07:44:26 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:49012 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343Ab1CVLoW (ORCPT ); Tue, 22 Mar 2011 07:44:22 -0400 Date: Tue, 22 Mar 2011 12:44:05 +0100 From: Ingo Molnar To: Lucas De Marchi Cc: Linus Torvalds , Andrew Morton , Lucas De Marchi , linux-kernel@vger.kernel.org, trivial@kernel.org, Randy Dunlap , jason.wessel@windriver.com Subject: Re: [PATCH 2/4] perf: fix common misspellings Message-ID: <20110322114405.GE4448@elte.hu> References: <1300455630-21577-1-git-send-email-lucas.demarchi@profusion.mobi> <1300455630-21577-2-git-send-email-lucas.demarchi@profusion.mobi> <20110322103735.GD4448@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2337 Lines: 58 * Lucas De Marchi wrote: > Hi Ingo, > > [ CC'ing Randy Dunlap and Jason Wessel ] > > On Tue, Mar 22, 2011 at 07:37, Ingo Molnar wrote: > > > > * Lucas De Marchi wrote: > > > >> They were generated by 'codespell' and then manually reviewed. > >> > >> Signed-off-by: Lucas De Marchi > >> --- > >> ?arch/mips/kernel/perf_event_mipsxx.c | ? ?2 +- > >> ?arch/powerpc/kernel/perf_event.c ? ? | ? ?2 +- > >> ?arch/sparc/kernel/perf_event.c ? ? ? | ? ?2 +- > >> ?arch/x86/kernel/cpu/perf_event.c ? ? | ? ?2 +- > >> ?arch/x86/kernel/cpu/perf_event_p4.c ?| ? ?8 ++++---- > >> ?include/linux/perf_event.h ? ? ? ? ? | ? ?2 +- > >> ?tools/perf/util/string.c ? ? ? ? ? ? | ? ?2 +- > >> ?7 files changed, 10 insertions(+), 10 deletions(-) > > > > Hm, half of these do not apply anymore. > > > > Since they are auto-generated, mind sending one large spelling fixes patch to > > Linus (for the whole kernel), at the end of the merge window, instead of these > > zillions of small commits which just clutter the patchflow? That makes it a > > heck of a lot easier to verify and handle for everyone involved. > > I agree with you, but last time I tried a large patch for fixing this > I've been told to split the patches for each maintainer > (http://kerneltrap.org/mailarchive/linux-kernel/2010/9/7/4616618). As > you noticed it's a pain to apply them and it's even more for splitting > in a per maintainer basis since it touches a lot of files. > > Randy, Jason: as you see maybe the split approach was not a good one. > > I'am all for applying this once, as Ingo said. Well, ultimately it's up to Linus (i've Cc:-ed him). For such pure spelling fixes i think what matters most is the timing, so that it impacts outstanding trees in the smallest possible way. For that the best timing would right before -rc1 - i.e. this week - as that is the moment when the outstanding queues are the shortest. Could you send the diffstat of the big, combined patch - how large is it total? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/