Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755785Ab1CVMh5 (ORCPT ); Tue, 22 Mar 2011 08:37:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755264Ab1CVMh4 (ORCPT ); Tue, 22 Mar 2011 08:37:56 -0400 Message-ID: <4D889807.6000307@redhat.com> Date: Tue, 22 Mar 2011 14:37:27 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jean-philippe.menil@univ-nantes.fr, stable@kernel.org, Jason Wang Subject: Re: [PATCH] kvm: fix crash on irqfd deassign References: <20110317085333.GA7336@redhat.com> In-Reply-To: <20110317085333.GA7336@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 889 Lines: 25 On 03/17/2011 10:53 AM, Michael S. Tsirkin wrote: > irqfd in kvm used flush_work incorrectly: > it assumed that work scheduled previously can't run > after flush_work, but since kvm uses a non-reentrant > workqueue (by means of schedule_work) > we need flush_work_sync to get that guarantee. > > Signed-off-by: Michael S. Tsirkin > Reported-by: Jean-Philippe Menil > Tested-by: Jean-Philippe Menil > --- > > Note: this is needed for kernel 2.6.39 and earlier. > What about kvm.git master? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/