Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932110Ab1CVM7d (ORCPT ); Tue, 22 Mar 2011 08:59:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2726 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754228Ab1CVM73 convert rfc822-to-8bit (ORCPT ); Tue, 22 Mar 2011 08:59:29 -0400 From: Jeff Moyer To: "Martin K. Petersen" Cc: Geert Uytterhoeven , James Bottomley , Andrew Morton , Linus Torvalds , linux-scsi , linux-kernel Subject: Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window References: <1300392635.17266.5.camel@mulgrave.site> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 22 Mar 2011 08:59:14 -0400 In-Reply-To: (Martin K. Petersen's message of "Tue, 22 Mar 2011 00:27:42 -0400") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 29 "Martin K. Petersen" writes: >>>>>> "Geert" == Geert Uytterhoeven writes: > > Geert> drivers/scsi/sd.c: In function ‘sd_prep_fn’: > Geert> drivers/scsi/sd.c:544: warning: ‘ret’ may be used uninitialized > Geert> in this function > > Sorry about that. > > > sd: Fail discard requests when logical block provisioning has been disabled > > Ensure that we kill discard requests after logical block provisioning > has been disabled in sysfs. > > Signed-off-by: Martin K. Petersen > Reported-by: Geert Uytterhoeven Tao Ma posted a similar patch. Anyway, either looks good to me. This one will avoid an unecessary extra setting of ret, but I doubt that matters. Reviewed-by: Jeff Moyer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/