Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753056Ab1CVS6X (ORCPT ); Tue, 22 Mar 2011 14:58:23 -0400 Received: from fxip-0047f.externet.hu ([88.209.222.127]:45059 "EHLO pomaz-ex.szeredi.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265Ab1CVS6V (ORCPT ); Tue, 22 Mar 2011 14:58:21 -0400 To: Linus Torvalds CC: viro@zeniv.linux.org.uk, miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, apw@canonical.com, nbd@openwrt.org, neilb@suse.de In-reply-to: (message from Linus Torvalds on Tue, 22 Mar 2011 11:48:11 -0700) Subject: Re: [PATCH 0/6 v7] overlay filesystem - request for inclusion References: <20110322152602.053930811@szeredi.hu> <20110322183919.GV22723@ZenIV.linux.org.uk> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: From: Miklos Szeredi Date: Tue, 22 Mar 2011 19:58:17 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 34 On Tue, 22 Mar 2011, Linus Torvalds wrote: > On Tue, Mar 22, 2011 at 11:39 AM, Al Viro wrote: > > > > Locking analysis would be really nice; AFAICS, it violates locking order > > when called from e.g. ->setattr() Locking order is always: -> overlayfs locks -> upper fs locks -> lower fs locks So it's really pretty simple and easy to validate. > > and its protection against renames is > > nowhere near enough.  I might be missing something subtle, but... Protection is exactly as for userspace callers. AFAICT. > Miklos - have you tried using this with lockdep (together with the > same filesystems mounted natively too)? I'd expect that that should > show any bad lock usage.. Ah, lockdep. I have tried, but there seems to be always something that triggers it at boot time on my laptop, which makes it useless. I could find some other machine to test this on, though. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/