Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754951Ab1CVTEf (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Mar 2011 15:04:35 -0400
Received: from relais.videotron.ca ([24.201.245.36]:25013 "EHLO
	relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753901Ab1CVTEc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Mar 2011 15:04:32 -0400
MIME-version: 1.0
Content-transfer-encoding: 7BIT
Content-type: TEXT/PLAIN; charset=US-ASCII
Date: Tue, 22 Mar 2011 15:04:16 -0400 (EDT)
From: Nicolas Pitre <nico@fluxnic.net>
X-X-Sender: nico@xanadu.home
To: Julia Lawall <julia@diku.dk>
Cc: kernel-janitors@vger.kernel.org, Chris Ball <cjb@laptop.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Miroslaw <mirq-linux@rere.qmqm.pl>,
        Anton Vorontsov <cbouatmailru@gmail.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Sascha Sommer <saschasommer@freenet.de>, linux-mmc@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] drivers/mmc/host/mvsdio.c: Convert release_resource to
 release_mem_region
In-reply-to: <1300814095-25278-1-git-send-email-julia@diku.dk>
Message-id: <alpine.LFD.2.00.1103221503100.11889@xanadu.home>
References: <1300814095-25278-1-git-send-email-julia@diku.dk>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1723
Lines: 62

On Tue, 22 Mar 2011, Julia Lawall wrote:

> Request_mem_region should be used with release_mem_region, not
> release_resource.
> 
> A semantic patch that partially fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @b@
> expression x,E;
> @@
> 
> x = request_mem_region(x->start,...)
> ... when != release_mem_region(x->start,...)
>     when != x = E
> (
> - release_resource(x);
> - kfree(x);
> +  release_mem_region(x->start,resource_size(x));
> |
> ?- release_resource(x);
> +  release_mem_region(x->start,resource_size(x));
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>

Acked-by: Nicolas Pitre <nico@fluxnic.net>

> ---
>  drivers/mmc/host/mvsdio.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index a5bf60e..4606087 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -825,7 +825,7 @@ out:
>  			iounmap(host->base);
>  	}
>  	if (r)
> -		release_resource(r);
> +		release_mem_region(r->start, resource_size(r));
>  	if (mmc)
>  		mmc_free_host(mmc);
>  
> @@ -850,7 +850,7 @@ static int __exit mvsd_remove(struct platform_device *pdev)
>  		del_timer_sync(&host->timer);
>  		mvsd_power_down(host);
>  		iounmap(host->base);
> -		release_resource(host->res);
> +		release_mem_region(host->res->start, resource_size(host->res));
>  		mmc_free_host(mmc);
>  	}
>  	platform_set_drvdata(pdev, NULL);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/