Date: Tue, 22 Mar 2011 15:22:59 -0700
From: Greg KH <gregkh@suse.de>
To: Alan Cox <alan@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Oren Weil <oren.jer.weil@intel.com>,
        linux-kernel@vger.kernel.org, david@woodhou.se
Subject: Re: [PATCH 1/7] char/mei: PCI device and char driver support.
Message-ID: <20110322222259.GA26362@suse.de>
References: <1300791092-14319-1-git-send-email-oren.jer.weil@intel.com>
 <1300791092-14319-2-git-send-email-oren.jer.weil@intel.com>
 <201103221822.43780.arnd@arndb.de>
 <20110322215759.2d982e06@bob.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110322215759.2d982e06@bob.linux.org.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 805
Lines: 20

On Tue, Mar 22, 2011 at 09:57:59PM +0000, Alan Cox wrote:
> > * In the PCI probe function, create a misc character device for
> >   every instance you find behind each device. Remove the global
> >   variables and constants.
> 
> The current code is complex and could be a ton simpler *but* don't
> abuse misc devices when you have one per PCI instance please.

The code specifically says it only supports one device in the system at
a time.  Since it can't do any more than that, why wouldn't it be
correct for a misdevice to be used here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/