Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754209Ab1CWBkE (ORCPT ); Tue, 22 Mar 2011 21:40:04 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:56863 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753046Ab1CWBkB (ORCPT ); Tue, 22 Mar 2011 21:40:01 -0400 Message-ID: <4D894CD0.9030509@cn.fujitsu.com> Date: Wed, 23 Mar 2011 09:28:48 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 MIME-Version: 1.0 To: zippel@linux-m68k.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, greg@kroah.com, joe@perches.com, akpm@linux-foundation.org Subject: Re: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c References: <20110322143839.GA10291@gmail.com> In-Reply-To: <20110322143839.GA10291@gmail.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-03-23 09:24:51, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-03-23 09:38:30, Serialize complete at 2011-03-23 09:38:30 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 40 Harry Wei wrote: > Hi us, > Clean up CodingStyle for scripts/kconfig/gconf.c. > What makes you think this is a bad style? Does Documentation/CodingStyle say so? Does checkpatch.pl make a complain? Do you really think this improves readability? I don't think so, and actually it makes the code worse. Run checkpatch.pl on this file, and you'll see lots of errors and warnings, but pure codingstyle cleanup is rarely worth anything, so better don't do that. > Thanks. > Best Regards. > Harry Wei. > > Signed-off-by: Harry Wei > --- > scripts/kconfig/gconf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c > index 4558961..56da945 100644 > --- a/scripts/kconfig/gconf.c > +++ b/scripts/kconfig/gconf.c > @@ -7,7 +7,7 @@ > */ > > #ifdef HAVE_CONFIG_H > -# include > +#include > #endif > > #include "lkc.h" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/