Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751093Ab1CWEHa (ORCPT ); Wed, 23 Mar 2011 00:07:30 -0400 Received: from linux-sh.org ([111.68.239.195]:51598 "EHLO linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752Ab1CWEH3 (ORCPT ); Wed, 23 Mar 2011 00:07:29 -0400 Date: Wed, 23 Mar 2011 13:07:04 +0900 From: Paul Mundt To: Stephen Boyd Cc: Guan Xuetao , "'Russell King - ARM Linux'" , linux-arm-kernel@lists.infradead.org, "'Arnd Bergmann'" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h Message-ID: <20110323040704.GA15808@linux-sh.org> References: <1300751462-1494-1-git-send-email-sboyd@codeaurora.org> <201103220934.50435.arnd@arndb.de> <20110322092113.GB17264@n2100.arm.linux.org.uk> <201103221110.20861.arnd@arndb.de> <00ec01cbe897$2eed7210$8cc85630$@mprc.pku.edu.cn> <4D88ECE3.1070209@codeaurora.org> <00fc01cbe8f9$cd807640$688162c0$@mprc.pku.edu.cn> <4D896616.7070307@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D896616.7070307@codeaurora.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1414 Lines: 28 On Tue, Mar 22, 2011 at 08:16:38PM -0700, Stephen Boyd wrote: > On 03/22/2011 06:29 PM, Guan Xuetao wrote: > > IMO, the content of asm-generic/sizes.h should only include > > power-of-2 sizes definitions. And SZ_48M could be replaced by > > (SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific > > headers. > > I'm hoping that kbuild gets asm-generic support sometime soon so files > with only a "#include " are generated instead of living > in the tree. In that case I'd rather have the non power of 2 constants > added to the generic sizes.h and be done with it. There isn't any strong > technical reason to deny power of 2 constants from the generic header, > right? > > Note: SH could also move to this if SZ_26M is put in the generic header. > I since dropped it and just open-coded it in the one place it was being used. If it had been used in more places I would have stubbed it in the asm/ version after the asm-generic include. I'd say the simplest is to stay with powers of 2 unless you have a size that is used in more than one place. If ARM uses SZ_48M commonly then there's certainly a good case for adding it generically. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/