From: Arnd Bergmann <arnd@arndb.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/7] char/mei: PCI device and char driver support.
Date: Wed, 23 Mar 2011 08:59:12 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; )
Cc: Greg KH <gregkh@suse.de>, Alan Cox <alan@linux.intel.com>,
        Oren Weil <oren.jer.weil@intel.com>, linux-kernel@vger.kernel.org,
        david@woodhou.se
References: <1300791092-14319-1-git-send-email-oren.jer.weil@intel.com> <20110322222259.GA26362@suse.de> <20110322230437.0a2668e2@lxorguk.ukuu.org.uk>
In-Reply-To: <20110322230437.0a2668e2@lxorguk.ukuu.org.uk>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201103230859.12759.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1176
Lines: 29

On Wednesday 23 March 2011, Alan Cox wrote:
> On Tue, 22 Mar 2011 15:22:59 -0700
> Greg KH <gregkh@suse.de> wrote:
> 
> > On Tue, Mar 22, 2011 at 09:57:59PM +0000, Alan Cox wrote:
> > > > * In the PCI probe function, create a misc character device for
> > > >   ". Remove the global
> > > >   variables and constants.
> > > 
> > > The current code is complex and could be a ton simpler but don't
> > > abuse misc devices when you have one per PCI instance please.
> > 
> > The code specifically says it only supports one device in the system at
> > a time.  Since it can't do any more than that, why wouldn't it be
> > correct for a misdevice to be used here?
> 
> Arnd was suggesting one device for "every instance you find behind each
> device" so that isn't a good idea for a misc device given there will be
> lots of them.

Yes, makes sense. I was assuming that the common case was that there
is only a single instance.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/