Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932248Ab1CWIpG (ORCPT ); Wed, 23 Mar 2011 04:45:06 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:60857 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755857Ab1CWIpD (ORCPT ); Wed, 23 Mar 2011 04:45:03 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Minchan Kim Subject: Re: [PATCH 1/5] vmscan: remove all_unreclaimable check from direct reclaim path completely Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org, Andrew Morton , David Rientjes , Linus Torvalds , Rik van Riel , Oleg Nesterov , linux-mm , Andrey Vagin , Hugh Dickins , KAMEZAWA Hiroyuki , Nick Piggin , Johannes Weiner In-Reply-To: <20110323082423.GA1969@barrios-desktop> References: <20110323161354.1AD2.A69D9226@jp.fujitsu.com> <20110323082423.GA1969@barrios-desktop> Message-Id: <20110323174545.1AE2.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.56.05 [ja] Date: Wed, 23 Mar 2011 17:44:59 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 865 Lines: 21 > > Boo. > > You seems forgot why you introduced current all_unreclaimable() function. > > While hibernation, we can't trust all_unreclaimable. > > Hmm. AFAIR, the why we add all_unreclaimable is when the hibernation is going on, > kswapd is freezed so it can't mark the zone->all_unreclaimable. > So I think hibernation can't be a problem. > Am I miss something? Ahh, I missed. thans correct me. Okay, I recognized both mine and your works. Can you please explain why do you like your one than mine? btw, Your one is very similar andrey's initial patch. If your one is better, I'd like to ack with andrey instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/