Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932975Ab1CWOvU (ORCPT ); Wed, 23 Mar 2011 10:51:20 -0400 Received: from mout.perfora.net ([74.208.4.195]:59063 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932625Ab1CWOvS (ORCPT ); Wed, 23 Mar 2011 10:51:18 -0400 From: Stephen Wilson To: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Cc: Andrew Morton , Alexander Viro , Michel Lespinasse , Andi Kleen , Rik van Riel , KOSAKI Motohiro , Matt Mackall , David Rientjes , Nick Piggin , Andrea Arcangeli , Mel Gorman , Hugh Dickins , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Stephen Wilson Subject: [PATCH v2 resend 12/12] proc: enable writing to /proc/pid/mem Date: Wed, 23 Mar 2011 10:44:01 -0400 Message-Id: <1300891441-16280-13-git-send-email-wilsons@start.ca> X-Mailer: git-send-email 1.7.3.5 In-Reply-To: <1300891441-16280-1-git-send-email-wilsons@start.ca> References: <1300891441-16280-1-git-send-email-wilsons@start.ca> X-Provags-ID: V02:K0:bgC+meV6kPmVmJfMMvRDrClAfmH0lkoPQkN2TDXADLJ +OU7xRJ453Po06zXbKWI2lVuHOTnoP8qnGxAZC3HjxQYquHvrv 4OiantagDPN9hgXX8+lHlhwDHL54I1k2k6HLgg4tKXWlU2i2+O IRIWGUXgCCwg6PpBmuidPps3qaOBS/R6yCwUHqdRRledbIpTKE 8oAiYWkgij3eE6ybPvVlNL5P1bdSpdwIOZ/T1MCvuQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 39 With recent changes there is no longer a security hazard with writing to /proc/pid/mem. Remove the #ifdef. Signed-off-by: Stephen Wilson --- fs/proc/base.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index ebe3c47..a0cfcd4 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -852,10 +852,6 @@ out_no_task: return ret; } -#define mem_write NULL - -#ifndef mem_write -/* This is a security hazard */ static ssize_t mem_write(struct file * file, const char __user *buf, size_t count, loff_t *ppos) { @@ -912,7 +908,6 @@ out_task: out_no_task: return copied; } -#endif loff_t mem_lseek(struct file *file, loff_t offset, int orig) { -- 1.7.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/