DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=jMLdKgzN0OpvnYnNfXlIDmlWlNMovsk6KezTrZPQGLWCU8/DVzt9sr9wVrNiF80aDf
         X6YC60ndeFkp5PA3PY+rHHaYrByq1KG/mGZPqp8SttGewtmbo/1LPs3TedfFkXDqCJOn
         Vjym1vwNWAt500BRCa6TeTWZUkdp/WDE1AN20=
MIME-Version: 1.0
In-Reply-To: <1300887554-19031-2-git-send-email-jic23@cam.ac.uk>
References: <1300887554-19031-1-git-send-email-jic23@cam.ac.uk>
	<1300887554-19031-2-git-send-email-jic23@cam.ac.uk>
Date: Wed, 23 Mar 2011 17:30:11 +0200
Message-ID: <AANLkTimeEKjVwwYi+twb0oeoFK-33LMx5aQBZEnPodne@mail.gmail.com>
Subject: Re: [PATCH 1/3] Add a kstrtobool function matching semantics of
 existing in kernel equivalents.
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, rusty@rustcorp.com.au
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 879
Lines: 31

On Wed, Mar 23, 2011 at 3:39 PM, Jonathan Cameron <jic23@cam.ac.uk> wrote:
> +int kstrtobool(const char *s, bool *res)
> +{
> + ? ? ? switch (s[0]) {
> + ? ? ? case 'y':
> + ? ? ? case 'Y':
> + ? ? ? case '1':
> + ? ? ? ? ? ? ? *res = true;
> + ? ? ? case 'n':
> + ? ? ? case 'N':
> + ? ? ? case '0':
> + ? ? ? ? ? ? ? *res = false;
> + ? ? ? default:
> + ? ? ? ? ? ? ? return -EINVAL;
> + ? ? ? }
> + ? ? ? return 0;
> +}

sigh... such simple thing and so many bugs

The only values such function should accept is 0 and 1.

Have you read the rest of kstrto*() code?
Where is newline check?

Anyway, I think it's better do not exist.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/