Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933520Ab1CXAYI (ORCPT ); Wed, 23 Mar 2011 20:24:08 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:43838 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933494Ab1CXAYE convert rfc822-to-8bit (ORCPT ); Wed, 23 Mar 2011 20:24:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=e0jv6F1nPqQHWbmq52zAnX6WW6GK4mQ8MzQKHORZz8z7IgxIj7s8cDLUzamoQQUy7i SBcH1E+qFACp7bASeUgygHnGZgl/F/YwV5v+8V+vMet9qYx+PDnwHj9ZAhqQcAfo27cW dxA6v/8+u+0mvyfx/YM/BQrVB14NvVTIkBXlo= MIME-Version: 1.0 In-Reply-To: <1300919616-6780-1-git-send-email-Kyle.D.Moffett@boeing.com> References: <091F7EC1-5D33-4C90-AFC1-D6E24EF3EEC6@boeing.com> <1300919616-6780-1-git-send-email-Kyle.D.Moffett@boeing.com> Date: Wed, 23 Mar 2011 19:24:04 -0500 Message-ID: Subject: Re: [RFC PATCH] et1011c: Replaced PHY driver by a small dm646x board fixup From: Andy Fleming To: Kyle Moffett Cc: netdev@vger.kernel.org, Kevin Hilman , Russell King , "David S. Miller" , =?ISO-8859-1?Q?Uwe_Kleine=2DK=F6nig?= , "David J. Choi" , Giuseppe Cavallaro , Randy Dunlap , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 28 On Wed, Mar 23, 2011 at 5:33 PM, Kyle Moffett wrote: > - > -static struct phy_driver et1011c_driver = { > - ? ? ? .phy_id ? ? ? ? = 0x0282f014, > - ? ? ? .name ? ? ? ? ? = "ET1011C", > - ? ? ? .phy_id_mask ? ?= 0xfffffff0, > - ? ? ? .features ? ? ? = (PHY_BASIC_FEATURES | SUPPORTED_1000baseT_Full), > - ? ? ? .flags ? ? ? ? ?= PHY_POLL, > - ? ? ? .config_aneg ? ?= et1011c_config_aneg, > - ? ? ? .read_status ? ?= et1011c_read_status, > - ? ? ? .driver ? ? ? ? = { .owner = THIS_MODULE,}, > -}; Might I suggest that you not eliminate the whole driver? If you leave just this part (and the init stuff below it), and convert the config_aneg and read_status pointers to use the genphy versions, the kernel will, at least, be able to report what type of PHY it is. And maybe one day, someone who is familiar with the inner workings of this PHY will fill in a more correct driver. Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/