Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933837Ab1CXTF6 (ORCPT ); Thu, 24 Mar 2011 15:05:58 -0400 Received: from smtp103.prem.mail.ac4.yahoo.com ([76.13.13.42]:23548 "HELO smtp103.prem.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933826Ab1CXTFz (ORCPT ); Thu, 24 Mar 2011 15:05:55 -0400 X-Yahoo-SMTP: _Dag8S.swBC1p4FJKLCXbs8NQzyse1SYSgnAbY0- X-YMail-OSG: L3n3ONAVM1k7uhjLc53s0UW90D8rNnEtQ5ycsbQogz6Rmjs x91LKewA.JxKHlCXVZ8dAoSkhgS_q5EROKGpbNhy.r3O.hMlIX9anIr3VhYN LNNAb2bEjjKxGBzp9ZGIejfcHwCWlmPlHIBj8uuX_A9pX7u4aOBLb2jsWPnd ubpeV05yx.rA6kJtvOG3sLB5pzf8BNwmBl4RoauOR7Ats7XuNoS7L37yuiwz PJls442hl_JE4agw8enGcCWqQ8W0Is89MkotD7M4kYPGdcCPgqSpIBWK92y3 20HcR1xmWVqMXnMDJlGKWU8fzUnfj5j8aMeILEw.g2z8k9PcG X-Yahoo-Newman-Property: ymail-3 Date: Thu, 24 Mar 2011 14:05:51 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@router.home To: Pekka Enberg cc: Ingo Molnar , Eric Dumazet , torvalds@linux-foundation.org, akpm@linux-foundation.org, tj@kernel.org, npiggin@kernel.dk, rientjes@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [GIT PULL] SLAB changes for v2.6.39-rc1 In-Reply-To: Message-ID: References: <20110324172653.GA28507@elte.hu> <1300990853.3747.189.camel@edumazet-laptop> <20110324185903.GA30510@elte.hu> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 38 On Thu, 24 Mar 2011, Pekka Enberg wrote: > It hanged here which is pretty much expected on this box if > kmem_cache_init() oopses. I'm now trying to see if I'm able to find > the config option that breaks things. CONFIG_PREEMPT_NONE is a > suspect: > > penberg@tiger:~/linux$ grep PREEMPT ../config-ingo > # CONFIG_PREEMPT_RCU is not set > CONFIG_PREEMPT_NONE=y > # CONFIG_PREEMPT_VOLUNTARY is not set > # CONFIG_PREEMPT is not set The following patch should ensure that all percpu data is touched before any emulation functions are called: --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c 2011-03-24 14:03:10.000000000 -0500 +++ linux-2.6/mm/slub.c 2011-03-24 14:04:08.000000000 -0500 @@ -1604,7 +1604,7 @@ static inline void note_cmpxchg_failure( void init_kmem_cache_cpus(struct kmem_cache *s) { -#if defined(CONFIG_CMPXCHG_LOCAL) && defined(CONFIG_PREEMPT) +#ifdef CONFIG_CMPXCHG_LOCAL int cpu; for_each_possible_cpu(cpu) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/