Date: Tue, 16 Jul 2002 23:10:03 +0200
From: Filip Van Raemdonck <filipvr@xs4all.be>
To: linux-kernel@vger.kernel.org
Cc: fischer@norbit.de, marcelo@conectiva.com.br
Subject: [PATCH] aha152x fix
Message-ID: <20020716231003.A488@lucretia.debian.net>
Mail-Followup-To: linux-kernel@vger.kernel.org, fischer@norbit.de,
	marcelo@conectiva.com.br
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.20i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1278
Lines: 42

Hi,

I upgraded from 2.4.19-pre7 to -rc1 and this resulted in my aha152x card not
working anymore. (The error was "trying software interrupt, lost")

Below is a patch which makes it work again. Note that this is just reverting
a minimal part of the last applied patch to aha152x.c; so this may only be
fixing the symptom and not the problem.

Can somebody confirm if this is correct or not, and give some more insight
into this behaviour?


Regards,

Filip

--- aha152x.c.orig	Tue Jul 16 22:20:57 2002
+++ aha152x.c	Tue Jul 16 21:43:51 2002
@@ -1366,11 +1366,13 @@
 		}
 		HOSTDATA(shpnt)->swint = 0;
 
 		printk(KERN_INFO "aha152x%d: trying software interrupt, ", HOSTNO);
 		SETPORT(DMACNTRL0, SWINT|INTEN);
+		spin_unlock_irq (&io_request_lock);
 		mdelay(1000);
+		spin_lock_irq (&io_request_lock);
 		free_irq(shpnt->irq, shpnt);
 
 		if (!HOSTDATA(shpnt)->swint) {
 			if (TESTHI(DMASTAT, INTSTAT)) {
 				printk("lost.\n");

-- 
"Microsoft shouldn't be broken up.  It should be shut down."
	-- Phil Agre on the ILOVEYOU virus.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/