Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934170Ab1CXU2d (ORCPT <rfc822;w@1wt.eu>);
	Thu, 24 Mar 2011 16:28:33 -0400
Received: from mail-iy0-f174.google.com ([209.85.210.174]:59120 "EHLO
	mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756392Ab1CXU2b convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 24 Mar 2011 16:28:31 -0400
MIME-Version: 1.0
In-Reply-To: <4D8B9F6F.5010705@canonical.com>
References: <1300988652-25353-1-git-send-email-chase.douglas@canonical.com>
	<AANLkTimv3ZVQmgB-tbMthCYdEsK3Spk0WY9Vs9VLQEVs@mail.gmail.com>
	<4D8B9F6F.5010705@canonical.com>
Date: Thu, 24 Mar 2011 15:28:29 -0500
Message-ID: <AANLkTi=yigMtJgK715vuEBejcOS2hoZWN+tLWkS10Ykw@mail.gmail.com>
Subject: Re: [PATCH v3] Documentation: Add evdev type and code definitions
From: Chris Bagwell <chris@cnpbagwell.com>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Henrik Rydberg <rydberg@euromail.se>,
        Peter Hutterer <peter.hutterer@who-t.net>,
        Nikolai Kondrashov <spbnick@gmail.com>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3480
Lines: 92

On Thu, Mar 24, 2011 at 2:45 PM, Chase Douglas
<chase.douglas@canonical.com> wrote:
> On 03/24/2011 02:44 PM, Chris Bagwell wrote:
>> Looking good. ?Minor comments at end.
>>
>> On Thu, Mar 24, 2011 at 12:44 PM, Chase Douglas
>> <chase.douglas@canonical.com> wrote:
>>> +Touchscreens:
>>> +----------
>>> +ABS_{X,Y} must be reported with the location of the touch. BTN_TOUCH must be
>>> +used to report when a touch is active on the screen.
>>> +BTN_{MOUSE,LEFT,MIDDLE,RIGHT} must not be reported. BTN_TOOL_<name> events
>>> +should be reported where possible.
>>
>> Does the real button event restriction solve something? ?I know
>> majority of touchscreens are not sending a button today but usually
>> there is a button on the touchscreen frame that I'd image at least
>> some devices hooking it up to touchscreen interface.
>>
>> stylus+touchscreen combo devices are surely going to want to do this.
>
> Perhaps this should be more clearly for touchscreen-only devices (not
> tablets or a mix). The problem we end up seeing is drivers who use
> BTN_LEFT because they want a touch to generate a primary button press in
> X. I want to prevent people from doing this.

Oh, yes.  We do not want that for sure.  I thought you were talking
about "real" buttons and not something from a touch.  I would have
gotten it on first read if it said "BTN_* must not be reported as a
result of active touch."

>
> I believe mixed devices are hard to detect between tablets and
> stylus+touchscreen right now, as evidenced by the X evdev driver not
> handling the former by default while wacom is often used for the latter.
> However, with the device properties a userspace driver should be able to
> tell the two apart.
>
> I'll rename this guideline: Touchscreens without stylus tools. Any issues?

I think either original name or new name is fine.  The above intent
doesn't change even on combo devices.

>
>>> +
>>> +Trackpads:
>>> +----------
>>> +Legacy trackpads that only provide relative position information must report
>>> +events like mice described above.
>>> +
>>> +Trackpads that provide absolute touch position must report ABS_{X,Y} for the
>>> +location of the touch. BTN_TOUCH should be used to report when a touch is active
>>> +on the trackpad. Where multi-finger support is available, BTN_TOOL_<name> should
>>> +be used to report the number of touches active on the trackpad.
>>
>> How about a Tablet?
>>
>> Something like:
>>
>> Tablets:
>> --------
>>
>> BTN_TOOL_<name> events must be reported when a stylus or other tool is
>> active on tablet. ?ABS_{X,Y} must be reported with the location of the
>> tool. BTN_TOUCH should be used to report when the tool is in contact
>> with the tablet. BTN_{STYLUS,STLUS2} should be used to report buttons
>> on tool itself and BTN_{LEFT,MIDDLE,RIGHT,1,2,etc} should be used to
>> report buttons on tablet.
>
> Thanks for the addition! I'll add it in and add you on a SOB line if
> that's alright with you.

Sure thing.

Chris

>
>> Some tablets send ABS_PRESSURE with no BTN_TOUCH (why I said should
>> instead of must). ?Probably this is not worth mentioning here?
>
> Yeah, I'd leave that off as I think we want to set the guidelines to use
> BTN_TOUCH.
>
> Thanks,
>
> -- Chase
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/