Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757269Ab1CXV6Q (ORCPT ); Thu, 24 Mar 2011 17:58:16 -0400 Received: from kroah.org ([198.145.64.141]:45065 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755846Ab1CXV6N (ORCPT ); Thu, 24 Mar 2011 17:58:13 -0400 Date: Thu, 24 Mar 2011 14:57:54 -0700 From: Greg KH To: David Miller Cc: shemminger@vyatta.com, serge.hallyn@ubuntu.com, bhutchings@solarflare.com, eparis@redhat.com, eparis@parisplace.org, segoon@openwall.com, linux-kernel@vger.kernel.org, mjt@tls.msk.ru, arnd@arndb.de, mirqus@gmail.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, eric.dumazet@gmail.com, therbert@google.com, xiaosuo@gmail.com, jesse@nicira.com, kees.cook@canonical.com, eugene@redhat.com, dan.j.rosenberg@gmail.com, akpm@linux-foundation.org, sds@tycho.nsa.gov, linux-security-module@vger.kernel.org, dwalsh@redhat.com, dhowells@redhat.com Subject: Re: [PATCH v2] net: don't allow CAP_NET_ADMIN to load non-netdev kernel modules Message-ID: <20110324215754.GA12023@kroah.com> References: <1300991584.2689.35.camel@bwh-desktop> <20110324202634.GB9191@peq.hallyn.com> <20110324143944.29f4c362@nehalam> <20110324.144628.58411809.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110324.144628.58411809.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 33 On Thu, Mar 24, 2011 at 02:46:28PM -0700, David Miller wrote: > From: Stephen Hemminger > Date: Thu, 24 Mar 2011 14:39:44 -0700 > > > This breaks for many of the tunneling protocols, that rely on > > autoload for names like "sit0" > > Frankly I'm very disappointed in the fallout this has been causing. > > Everyone supporting this change, get real, and admit it doing in fact > cause a serious regression. > > If you can't get past that simple fact, you cannot discuss this issue > intelligently. > > You can't say "userland will fix things up" > > Because we're never supposed to break userland in the first place. > > There is simply no excuse for this and I want this change reverted > both in Linus's tree and in -stable. Ok, as I totally got lost in the thread here, what is the git commit id of the patch to revert? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/