Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757326Ab1CXWLJ (ORCPT ); Thu, 24 Mar 2011 18:11:09 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:43207 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757287Ab1CXWLH convert rfc822-to-8bit (ORCPT ); Thu, 24 Mar 2011 18:11:07 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=gingP+xl2gtCyntx+9l35EdU4MIL8+PPIXsJN757xt7POLEMnXzUyXaabwPbbfxyRR YXEuQQjRiVwls1ppiMGxJxxgo50IFzaq+1h5/2qLLifaUV4dCoHNZ7ri8xz1s8ORsRSA RQWDKJTB6/p09W9M1I4rhRGrufogXjL+zmVQY= MIME-Version: 1.0 In-Reply-To: <1300992308.3747.205.camel@edumazet-laptop> References: <1300980118.3747.42.camel@edumazet-laptop> <1300983340.3747.44.camel@edumazet-laptop> <1300986084.3747.101.camel@edumazet-laptop> <1300992308.3747.205.camel@edumazet-laptop> Date: Thu, 24 Mar 2011 23:11:06 +0100 Message-ID: Subject: Re: [PATCH] ipv4: fix fib metrics From: Alessandro Suardi To: Eric Dumazet Cc: David Miller , linux-kernel@vger.kernel.org, netdev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1988 Lines: 56 On Thu, Mar 24, 2011 at 7:45 PM, Eric Dumazet wrote: > Le jeudi 24 mars 2011 ? 19:14 +0100, Alessandro Suardi a ?crit : > >> >> I will however make one more bug report, as vpnc is broken before >> ?and after this patch - have to dig out what vpnc-script tries to do, >> ?which results in >> >> Error: either "to" is duplicate, or "ipid" is a garbage. >> >> ?after establishing the VPN tunnel. >> > > try following patch > > http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=406b6f974dae76a5b795d5c251d11c979a4e509b That one doesn't work. On a -git14 kernel + both the fib metrics and the above git diff, I strace'd vpnc and found out this (first triplet of public IP masked intentionally) [root@duff tmp]# egrep 'execve|garbage' strace.log |egrep '/ip|garbage' [pid 4228] execve("/sbin/ip", ["/sbin/ip", "route", "get", "xxx.9.13.212"], [/* 32 vars */]) = 0 [pid 4231] execve("/sbin/ip", ["/sbin/ip", "route", "replace", "10.175.0.0/19", "dev", "tun0"], [/* 32 vars */]) = 0 [pid 4232] execve("/sbin/ip", ["/sbin/ip", "route", "flush", "cache"], [/* 32 vars */]) = 0 [pid 4234] execve("/sbin/ip", ["/sbin/ip", "route", "get", "xxx.9.13.212"], [/* 32 vars */]) = 0 [pid 4237] execve("/sbin/ip", ["/sbin/ip", "route", "add", "xxx.9.13.212", "via", "192.168.1.1", "dev", "eth1", "src", "192.168.1.8", "ipid", "0x043f", "advmss", "1400"], [/* 32 vars */]) = 0 [pid 4237] write(2, "Error: either \"to\" is duplicate,"..., 57Error: either "to" is duplicate, or "ipid" is a garbage. 192.168.1.1 is my DSL router and 192.168.1.8 is my computer's wireless IP. Does this ring any bell ? Thanks, --alessandro ?"There's always a siren singing you to shipwreck" ?? (Radiohead, "There There") -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/