Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932967Ab1CYAcA (ORCPT ); Thu, 24 Mar 2011 20:32:00 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:5891 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754301Ab1CYAb7 (ORCPT ); Thu, 24 Mar 2011 20:31:59 -0400 From: "Tomoya MORINAGA" To: "'Peter Tyser'" , Cc: "'Grant Likely'" , "Toshiharu Okada" References: <1301008634-25429-1-git-send-email-ptyser@xes-inc.com> Subject: RE: [PATCH] gpio: ml_ioh_gpio: Fix output value of ioh_gpio_direction_output() Date: Fri, 25 Mar 2011 09:31:56 +0900 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 In-Reply-To: <1301008634-25429-1-git-send-email-ptyser@xes-inc.com> Thread-Index: AcvqeaMwr9S8V8qgR56zfA7EjTsOsQACaWdQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 29 Hi Peter, On Friday, March 25, 2011 8:17 AM, Peter Tyser wrote: > The ioh_gpio_direction_output() function was missing a write > to set the desired output value. The function would properly > set the GPIO direction, but not the output value. The value > would have to manually be set with a follow up call to ioh_gpio_set(). > This is untested - just noticed it while working on an > unrelated change. An ack or tested-by from someone with real > hardware would be appreciated. Thank you for your indication. Your saying is right. However since your patch looks incorrect, after testing, I will post new patch by next week. Thanks, ----------------------------------------- Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/