Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934059Ab1CYJd4 (ORCPT ); Fri, 25 Mar 2011 05:33:56 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:33923 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756062Ab1CYJdy (ORCPT ); Fri, 25 Mar 2011 05:33:54 -0400 Subject: Re: [PATCH 2/2] futex: Fix WARN_ON() test for UP From: Peter Zijlstra To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Lai Jiangshan , Darren Hart , Richard Weinberger In-Reply-To: <20110317192208.682654502@goodmis.org> References: <20110317192105.308382309@goodmis.org> <20110317192208.682654502@goodmis.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 25 Mar 2011 10:35:58 +0100 Message-ID: <1301045758.2250.154.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 24 On Thu, 2011-03-17 at 15:21 -0400, Steven Rostedt wrote: > From: Steven Rostedt > > An update of the futex code had a > > WARN_ON(!spin_is_locked(q->lock_ptr)) > > But on UP, spin_is_locked() is always false, and will > trigger this warning, and even worse, it will exit the function > without doing the necessary work. > > Converting this to a WARN_ON_SMP() fixes the problem. > > Reported-by: Richard Weinberger > Tested-by: Richard Weinberger > Signed-off-by: Steven Rostedt Acked-by: Peter Zijlstra -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/