Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757127Ab1CYL5t (ORCPT ); Fri, 25 Mar 2011 07:57:49 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:62780 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959Ab1CYL5r (ORCPT ); Fri, 25 Mar 2011 07:57:47 -0400 From: Arnd Bergmann To: Alexey Orishko Subject: Re: [RFC] usbnet: use eth%d name for known ethernet devices Date: Fri, 25 Mar 2011 12:57:32 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; ) Cc: Ben Hutchings , Steve Calfee , Michal Nazarewicz , Randy Dunlap , broonie@opensource.wolfsonmicro.com, lkml , Nicolas Pitre , Greg KH , David Brownell , Alan Cox , grant.likely@secretlab.ca, Linux USB list , andy.green@linaro.org, netdev@vger.kernel.org, Benjamin Herrenschmidt , roger.quadros@nokia.com, Jaswinder Singh , patches@linaro.org References: <4D79F068.2080009@linaro.org> <201103241415.45115.arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103251257.32714.arnd@arndb.de> X-Provags-ID: V02:K0:kG6gVD/Y9XJaJtQRR14ExJpVpsfQRzdedTrgckxR4yr jEqj6LT0TBLvlxciBRZMpTMICCmQDXStWIKpqQsYgWWzZ4eqZV 9HynEs3O26U8w/a0t3xYkckjL4d/naAnDR7IfJgS2xie9GqaJn qppxtECz7c+79EQbzkgdivTIPcu/EzDjtr5ejCLUsq8YMEH8N6 HcHS/QUBiPRWX7ZEFQOZQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1675 Lines: 38 On Thursday 24 March 2011, Alexey Orishko wrote: > On Thu, Mar 24, 2011 at 2:15 PM, Arnd Bergmann wrote: > > > > > The approach taken here is to flag whether a device might be a > > point-to-point link with the new FLAG_PTP setting in the usbnet > > driver_info. A driver can set both FLAG_PTP and FLAG_ETHER if > > it is not sure (e.g. cdc_ether), or just one of the two. > > > The usbnet framework only looks at the MAC address for device > > naming if both flags are set, otherwise it trusts the flag. > > Should this paragraph above be a clue for the flag name? > Sorry for late comment, but having flag called FLAG_POINTTOPOINT is really > confusing. ptp, p2p terms are heavily used and will mislead folks. > > Would it be better to call it something like IGNORE_MAC_ADDRESS if this is the > feature you are targeting? That would be a different way of looking at it. FLAG_POINTTOPOINT describes what the device is (a USB cable connecting two hosts), and that flag can be used for various things, where the only thing we currently do is the netif naming. FLAG_IGNORE_MAC_ADDRESS as you suggest describes the implementation of the device naming, not why that is done. The intent here was to some something that makes sense next to FLAG_ETHER, FLAG_WWAN and FLAG_WLAN. I think FLAG_POINTTOPOINT describes this best, although I'd also be happy with FLAG_PTP, FLAG_P2P, FLAG_CABLE or FLAG_USBCABLE. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/