From: Arnd Bergmann <arnd@arndb.de>
To: "Guan Xuetao" <gxt@mprc.pku.edu.cn>
Subject: Re: Warning with asm-generic/div64.h
Date: Fri, 25 Mar 2011 14:39:53 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
References: <007801cbead6$1984b6e0$4c8e24a0$@mprc.pku.edu.cn>
In-Reply-To: <007801cbead6$1984b6e0$4c8e24a0$@mprc.pku.edu.cn>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201103251439.53568.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1070
Lines: 31

On Friday 25 March 2011, Guan Xuetao wrote:
> Following warning is generated when using <asm-generic/div64.h>
> 
> kernel/power/hibernate.c: In function 'swsusp_show_speed':
> kernel/power/hibernate.c:227: warning: comparison of distinct pointer types lacks a cast
> 
> After expanding the do_div() macro, the problem line is:
> 
>         (void)(((typeof((n)) *)0) == ((uint64_t *)0));
> 
> while the type of n is s64.
> 
> I am puzzled with the usage of the problem line.
> 
> And how to correct it?

The purpose of this line is to generate a warning when the input is the
wrong type, as the comment says:
 /* The unnecessary pointer compare is there
  * to check for type safety (n must be 64bit)

The macro doesn't work for signed input or for 32 bit input. I'd suggest
fixing the caller to use an unsigned type.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/