Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754710Ab1CYRDN (ORCPT ); Fri, 25 Mar 2011 13:03:13 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:50897 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754261Ab1CYRDM (ORCPT ); Fri, 25 Mar 2011 13:03:12 -0400 Date: Fri, 25 Mar 2011 13:03:12 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Michal Nazarewicz cc: Greg Kroah-Hartman , Sergey Senozhatsky , Chris Wright , , Subject: Re: [PATCHv3] usb: core: Change usb_create_sysfs_intf_files()' return type to void In-Reply-To: <531a6364dd1220278e76479423ce697e32bf4082.1301003830.git.mina86@mina86.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 30 On Fri, 25 Mar 2011, Michal Nazarewicz wrote: > The usb_create_sysfs_intf_files() function always returned zero even > if it failed to create sysfs fails. Since this is a desired behaviour > there is no need to return return code at all. This commit changes > function's return type (form int) to void. > > Signed-off-by: Michal Nazarewicz > Cc: Sergey Senozhatsky > --- > drivers/usb/core/sysfs.c | 13 +++++-------- > drivers/usb/core/usb.c | 3 +-- > drivers/usb/core/usb.h | 2 +- > 3 files changed, 7 insertions(+), 11 deletions(-) > > On Fri, 25 Mar 2011 16:33:12 +0100, Alan Stern wrote: > > My style preference is to put the empty statement before the comment. > > It's unusual to have a comment appearing before a statement on the same > > line. For example: > > ; /* We don't care if the function fails */ > > Changed. And I agree, it looks better now. :) Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/