Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754940Ab1CYTrh (ORCPT ); Fri, 25 Mar 2011 15:47:37 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:62214 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753459Ab1CYTrf (ORCPT ); Fri, 25 Mar 2011 15:47:35 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=PvWpGtNVK2FD1sIwgu8ApdyYY+vT9nXpjoAUeCZlm7JseuvKwBaDZjW9z8uA8qsC0N +lxo9c5gxtQ9Q0j7TG34zRD/IPDgl0h0w+chX1VN+m6HL0b8LhNTlbuwdkOlgUAuGRYu sRs184mMecSzdAIF5xzrPRnOc6lfluVJMES2M= Date: Fri, 25 Mar 2011 21:47:29 +0200 From: Alexey Dobriyan To: Steven Rostedt Cc: Linus Torvalds , mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dvhart@linux.intel.com, peterz@infradead.org, akpm@linux-foundation.org, srostedt@redhat.com, tglx@linutronix.de, laijs@cn.fujitsu.com, mingo@elte.hu, linux-tip-commits@vger.kernel.org Subject: Re: [tip:core/urgent] WARN_ON_SMP(): Allow use in if() statements on UP Message-ID: <20110325194729.GA6192@p183.telecom.by> References: <20110317192208.444147791@goodmis.org> <1301076981.14261.197.camel@gandalf.stny.rr.com> <1301077163.14261.199.camel@gandalf.stny.rr.com> <20110325193128.GA5839@p183.telecom.by> <1301082034.14261.202.camel@gandalf.stny.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1301082034.14261.202.camel@gandalf.stny.rr.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 22 On Fri, Mar 25, 2011 at 03:40:34PM -0400, Steven Rostedt wrote: > On Fri, 2011-03-25 at 21:31 +0200, Alexey Dobriyan wrote: > > > > Would you like me to add a comment that states: > > > > > > /* > > > * Use ({0;}) as just "0" will cause gcc to output: > > > * warning: statement with no effect > > > */ > > > > Try ((void)0) > > Maybe I should update the comment to stop further confusion: Ah! I always thought if (WARN_ON(x)) is confusing and should be banned. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/