Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753968Ab1CZT0y (ORCPT ); Sat, 26 Mar 2011 15:26:54 -0400 Received: from mail.perches.com ([173.55.12.10]:4284 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535Ab1CZT0x (ORCPT ); Sat, 26 Mar 2011 15:26:53 -0400 Subject: Re: [PATCH 2/4] staging: keucr: smscsi: Includes missing KERN_ facility level to printk(). From: Joe Perches To: Ralf Thielow Cc: devel@driverdev.osuosl.org, gregkh@suse.de, linux-kernel@vger.kernel.org In-Reply-To: References: <1301156180-12192-1-git-send-email-ralf.thielow@googlemail.com> <1301156180-12192-2-git-send-email-ralf.thielow@googlemail.com> <1301165486.17567.7.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Sat, 26 Mar 2011 12:26:51 -0700 Message-ID: <1301167611.17567.12.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1402 Lines: 38 On Sat, 2011-03-26 at 20:11 +0100, Ralf Thielow wrote: > Of course, the whole staging directory with "make clean > M=drivers/staging && make M=drivers/staging". > You're right. The "printk" function accept these but it's wrong. Then you didn't really compile test it. I suggest you check your compilation commands. For instance: diff --git a/drivers/staging/keucr/smscsi.c b/drivers/staging/keucr/smscsi.c index 6211686..dd3cf95 100644 --- a/drivers/staging/keucr/smscsi.c +++ b/drivers/staging/keucr/smscsi.c @@ -98,7 +98,7 @@ int SM_SCSI_Read_Capacity(struct us_data *us, struct scsi_cmnd *srb) WORD bl_len; BYTE buf[8]; - printk("SM_SCSI_Read_Capacity\n"); + printk(KERN_DEBUG, "SM_SCSI_Read_Capacity\n"); bl_len = 0x200; bl_num = Ssfdc.MaxLogBlocks * Ssfdc.MaxSectors * Ssfdc.MaxZones - 1; $ make drivers/staging/keucr/smscsi.o CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CC drivers/staging/keucr/smscsi.o drivers/staging/keucr/smscsi.c: In function ‘SM_SCSI_Read_Capacity’: drivers/staging/keucr/smscsi.c:101:2: warning: too many arguments for format -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/