Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728Ab1C0IHe (ORCPT ); Sun, 27 Mar 2011 04:07:34 -0400 Received: from www.linutronix.de ([62.245.132.108]:51263 "EHLO linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280Ab1C0IHY (ORCPT ); Sun, 27 Mar 2011 04:07:24 -0400 Date: Sun, 27 Mar 2011 10:07:15 +0200 (CEST) From: Thomas Gleixner To: Colin Cross cc: Varun Wadekar , LKML , LAK , Russell King , Lennert Buytenhek , "linux-tegra@vger.kernel.org" Subject: Re: [patch 02/23] arm: tegra: Remove unused function which fiddles with irq_desc In-Reply-To: Message-ID: References: <20110325131617.258789658@linutronix.de> <20110325132047.552074703@linutronix.de> <4D8E4897.5030705@nvidia.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463795968-845400213-1301213237=:31464" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2292 Lines: 57 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463795968-845400213-1301213237=:31464 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT On Sat, 26 Mar 2011, Colin Cross wrote: > On Sat, Mar 26, 2011 at 1:24 PM, Thomas Gleixner wrote: > > On Sun, 27 Mar 2011, Varun Wadekar wrote: > >> > >> Thomas, then how do you think we should handle restoring of gpio states > >> across suspend-resume cycles? > > > > That code is unused. Period. No caller, nothing nada. So what does it > > handle? > > Tegra suspend support didn't make it into 2.6.39, but should get > merged in 2.6.40, and will call tegra_gpio_suspend/resume. > > >> > - > >> > - ? for (i = INT_GPIO_BASE; i < (INT_GPIO_BASE + TEGRA_NR_GPIOS); i++) { > >> > - ? ? ? ? ? struct irq_desc *desc = irq_to_desc(i); > >> > - ? ? ? ? ? if (!desc || (desc->status & IRQ_WAKEUP)) > >> > - ? ? ? ? ? ? ? ? ? continue; > >> > - ? ? ? ? ? enable_irq(i); > >> > - ? } > > > > And this part is totally unacceptable and should have never been > > merged. Further it is in the way of cleanups to the core code and as > > there is no user I'm not willing to even think about what it does and > > why it is there. > > > > FYI, the core code deals with interrupt suspending/resuming > > already. So if there is a problem with that which does not cover your > > specific problem, then you better talk to me before hacking up such > > private workarounds and expecting that I tolerate them in unused code. > > Yes, the existing code wrong, and unnecessary. It was copied from > mach-tegra/irq.c, which I later fixed, but I missed this one. I'll > take this patch for 2.6.39-rc1, which will prevent merge conflicts > between your tree and the tegra tree in 2.6.40. You can keep the functions if you need them anyway, but the irq fiddling needs to go now as it blocks core code cleanups. Thanks, tglx ---1463795968-845400213-1301213237=:31464-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/