Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445Ab1C0NVz (ORCPT ); Sun, 27 Mar 2011 09:21:55 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:49523 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753324Ab1C0NVw convert rfc822-to-8bit (ORCPT ); Sun, 27 Mar 2011 09:21:52 -0400 Date: Sun, 27 Mar 2011 14:21:35 +0100 From: Alan Cox To: Linus Torvalds Cc: Jens Axboe , Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , Chris Mason , "Linux/m68k" Subject: Re: [GIT PULL] Core block IO bits for 2.6.39 Message-ID: <20110327142135.376142dd@lxorguk.ukuu.org.uk> In-Reply-To: References: <4D8B4A89.80608@fusionio.com> <4D8D87B0.3080107@fusionio.com> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-14 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 23 On Sat, 26 Mar 2011 09:48:37 -0700 Linus Torvalds wrote: > On Fri, Mar 25, 2011 at 11:29 PM, Jens Axboe wrote: > > + > > + ? ? ? /* Use 3ms as that was the old plug delay */ > > + ? ? ? blk_delay_queue(q, msecs_to_jiffies(3)); > > That's bogus. blk_delay_queue() already takes msecs, not jiffies. > > Also, do we really need to delay every unplug like this? It seems sad. > A 3ms delay is a long time these days - admittedly most people > hopefully use ATA these days if they have an SSD or something, but > still.. The ATA code contains several other bogus delays btw. So out of the box unless you are using AHCI you are continually running small pointless delays every command issued. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/