Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816Ab1C1Cr3 (ORCPT ); Sun, 27 Mar 2011 22:47:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:12961 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760Ab1C1Cr2 (ORCPT ); Sun, 27 Mar 2011 22:47:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.63,252,1299484800"; d="scan'208";a="672224547" Message-ID: <4D8FF6BB.6030005@linux.intel.com> Date: Sun, 27 Mar 2011 19:47:23 -0700 From: Arjan van de Ven User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: Feng Tang CC: "Lu, Guanqun" , "meego-kernel@lists.meego.com" , "alan@linux.intel.com" , "Wu, Fengguang" , "Fu, Michael" , "Wang, Xingchao" , "Koul, Vinod" , "Kp, Jeeja" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , Feng Tang , Jacob Pan , Jekyll Lai , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v9 1/2] mrst: export get_gpio_by_name() function References: <1301279360-9839-1-git-send-email-guanqun.lu@intel.com> <1301279360-9839-2-git-send-email-guanqun.lu@intel.com> <4D8FF3AE.5060003@linux.intel.com> <20110328104719.78740624@feng-i7> In-Reply-To: <20110328104719.78740624@feng-i7> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 34 On 3/27/2011 7:47 PM, Feng Tang wrote: > On Mon, 28 Mar 2011 10:34:22 +0800 > Arjan van de Ven wrote: > >> On 3/27/2011 7:29 PM, Lu Guanqun wrote: >>> Export get_gpio_by_name() function and make its name more focused. >>> We are doing this because currently get_gpio_by_name() is only used >>> by the devices exported from SFI DEVS table, but it is also useful >>> for other PCI devices which also use the GPIO lines, and have their >>> gpio infos in the SFI GPIO table. >>> >> I can't say that I like the new name... at all. >> >> what's "mid" ? >> what is wrong with the original name???? >> > Hi Arjan, > > The original get_gpio_by_name() is static and only used in mrst.c as it's > mrst/mfld specific. So if we call it from a PCI driver, that name sounds get_gpio_by_name() would be a very good generic name for a function provided by the gpio layer as well. > like a platform independent general API while it's actually mrst/mfld bound. > So we would show this dependency from the function name. that makes no sense. and again, what on earth is a "mid"?????????? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/