Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919Ab1C1Hda (ORCPT ); Mon, 28 Mar 2011 03:33:30 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:60484 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605Ab1C1Hd3 (ORCPT ); Mon, 28 Mar 2011 03:33:29 -0400 From: OGAWA Hirofumi To: Kyungmin Park Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Lukas Czerner Subject: Re: [PATCH v5] fat: Batched discard support for fat References: <20110318020433.GA27263@july> <877hbkpo7v.fsf@devron.myhome.or.jp> <874o6n6a0e.fsf@devron.myhome.or.jp> Date: Mon, 28 Mar 2011 16:33:25 +0900 In-Reply-To: (Kyungmin Park's message of "Mon, 28 Mar 2011 15:56:42 +0900") Message-ID: <87y63z4s3e.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 944 Lines: 25 Kyungmin Park writes: >> Yes. It's what I'm saying. If user wants to trim 0-2 then user will >> specify 0-2, but this trims only 2. It's not right. > > There's similar code at ext4. it adjusts the start and len value if > given start is less than first_data_blk. > > if (start < first_data_blk) { > len -= first_data_blk - start; > start = first_data_blk; > } Oh, strange design. On this design, user have to know which block is actually start block per FSes (Yeah, you can still use this without start block knowledge. But it's bogus). I think it should fix ext4. No? Thanks. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/