Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787Ab1C1JsZ (ORCPT ); Mon, 28 Mar 2011 05:48:25 -0400 Received: from cantor.suse.de ([195.135.220.2]:52146 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551Ab1C1JsX (ORCPT ); Mon, 28 Mar 2011 05:48:23 -0400 Date: Mon, 28 Mar 2011 11:48:20 +0200 From: Michal Hocko To: KAMEZAWA Hiroyuki Cc: Daisuke Nishimura , Andrew Morton , linux-mm@kvack.org, LKML Subject: Re: [PATCH] memcg: update documentation to describe usage_in_bytes Message-ID: <20110328094820.GC5693@tiehlicka.suse.cz> References: <20110321102420.GB26047@tiehlicka.suse.cz> <20110322091014.27677ab3.kamezawa.hiroyu@jp.fujitsu.com> <20110322104723.fd81dddc.nishimura@mxp.nes.nec.co.jp> <20110322073150.GA12940@tiehlicka.suse.cz> <20110323092708.021d555d.nishimura@mxp.nes.nec.co.jp> <20110323133517.de33d624.kamezawa.hiroyu@jp.fujitsu.com> <20110328085508.c236e929.nishimura@mxp.nes.nec.co.jp> <20110328132550.08be4389.nishimura@mxp.nes.nec.co.jp> <20110328074341.GA5693@tiehlicka.suse.cz> <20110328181127.b8a2a1c5.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110328181127.b8a2a1c5.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1986 Lines: 60 On Mon 28-03-11 18:11:27, KAMEZAWA Hiroyuki wrote: > On Mon, 28 Mar 2011 09:43:42 +0200 > Michal Hocko wrote: > > > On Mon 28-03-11 13:25:50, Daisuke Nishimura wrote: > > > From: Daisuke Nishimura [...] > > > +5.5 usage_in_bytes > > > + > > > +As described in 2.1, memory cgroup uses res_counter for tracking and limiting > > > +the memory usage. memory.usage_in_bytes shows the current res_counter usage for > > > +memory, and DOESN'T show a actual usage of RSS and Cache. It is usually bigger > > > +than the actual usage for a performance improvement reason. > > > > Isn't an explicit mention about caching charges better? > > > > It's difficult to distinguish which is spec. and which is implemnation details... Sure. At least commit log should contain the implementation details IMO, though. > > My one here ;) > == > 5.5 usage_in_bytes > > For efficiency, as other kernel components, memory cgroup uses some optimization to > avoid unnecessary cacheline false sharing. usage_in_bytes is affected by the > method and doesn't show 'exact' value of usage, it's an fuzz value for efficient > access. (Of course, when necessary, it's synchronized.) > In usual, the value (RSS+CACHE) in memory.stat shows more exact value. IOW, - In usual, the value (RSS+CACHE) in memory.stat shows more exact value. IOW, + (RSS+CACHE) value from memory.stat shows more exact value and should be used + by userspace. IOW, ? > usage_in_bytes is less exact than memory.stat. The error will be larger on the larger > hardwares which have many cpus and tasks. > == > > Hmm ? Looks much better. Thanks -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/