Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005Ab1C1KV7 (ORCPT ); Mon, 28 Mar 2011 06:21:59 -0400 Received: from www.linutronix.de ([62.245.132.108]:50578 "EHLO linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331Ab1C1KV6 (ORCPT ); Mon, 28 Mar 2011 06:21:58 -0400 Date: Mon, 28 Mar 2011 12:21:53 +0200 (CEST) From: Thomas Gleixner To: Lukasz.Rymanowski@tieto.com cc: par-gunnar.p.hjalmdahl@stericsson.com, gregkh@suse.de, devel@driverdev.osuosl.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, pavan_savoy@sify.com, vitalywool@gmail.com, alan@lxorguk.ukuu.org.uk, arnd@arndb.de, marcel@holtmann.org, linus.walleij@stericsson.com, pghatwork@gmail.com, lee.jones@linaro.org, mathieu.poirier@linaro.org Subject: RE: [PATCH v2 1/2] staging: Add ST-Ericsson CG2900 driver In-Reply-To: <7D7F2FD3846CF6429ACEBDFB5A2DD86F07E35E5F89@EXMB01.eu.tieto.com> Message-ID: References: <1301302950-10628-1-git-send-email-par-gunnar.p.hjalmdahl@stericsson.com> <7D7F2FD3846CF6429ACEBDFB5A2DD86F07E35E5F89@EXMB01.eu.tieto.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 40 On Mon, 28 Mar 2011, Lukasz.Rymanowski@tieto.com wrote: > >> +/** > >> + * cts_interrupt() - Called to handle CTS interrupt. > >> + * @irq: Interrupt that occurred. > >> + * @dev_id: Device ID where interrupt occurred. > >> + * > >> + * The cts_interrupt() function is called if interrupt on CTS occurred. > >> + * It disables the interrupt and starts a new work thread to handle > >> + * the interrupt. > >> + */ > >> +static irqreturn_t cts_interrupt(int irq, void *dev_id) { > >> + struct uart_info *uart_info = dev_get_drvdata(dev_id); #ifdef > >> +CONFIG_PM > >> + disable_irq_wake(irq); > >> +#endif > >> + disable_irq_nosync(irq); > >> + > >> + /* Create work and leave IRQ context. */ > >> + (void)create_work_item(uart_info, handle_cts_irq); > >> + > >> + return IRQ_HANDLED; > >> +} > > >Have you thought about using a threaded interrupt handler? That would make all this work cruft go away. > > Good point. > To be honest we did think about it but in the time we where we were busy with other issues. > Anyway, shall we resend patches now or we can push patch for it once driver gets in the tree ? Up to Greg. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/