Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900Ab1C1Mvw (ORCPT ); Mon, 28 Mar 2011 08:51:52 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:48014 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111Ab1C1Mvv (ORCPT ); Mon, 28 Mar 2011 08:51:51 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=qtSRpiMJomddhL/a6cRFNnfbsaQCWWSL46ifj4xqWn6tHTrS88U1cAMIbRt+HFDpLj QYbQUIHkGSnv6qX4/EGDS2GR7C27hAV00MJvSglHznL1534tiFG5g4jIIKUfDlXTf60I 3jsUCILghmsmT+TbxhI1gl2ZV9jYwm94VhS3E= Subject: [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page From: Eric Dumazet To: Minchan Kim Cc: Andrew Morton , Johannes Weiner , linux-mm , LKML , Steven Barrett , Ben Gamari , Peter Zijlstra , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Wu Fengguang , Nick Piggin , Andrea Arcangeli , Balbir Singh , KAMEZAWA Hiroyuki In-Reply-To: <20110221155925.GA5641@barrios-desktop> References: <20110221084014.GC25382@cmpxchg.org> <20110221155925.GA5641@barrios-desktop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 28 Mar 2011 14:51:46 +0200 Message-ID: <1301316706.3182.27.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2669 Lines: 73 Le mardi 22 février 2011 à 00:59 +0900, Minchan Kim a écrit : > Fixed version. > > From be7d31f6e539bbad1ebedf52c6a51a4a80f7976a Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Tue, 22 Feb 2011 00:53:05 +0900 > Subject: [PATCH v7 2/3] memcg: move memcg reclaimable page into tail of inactive list > > The rotate_reclaimable_page function moves just written out > pages, which the VM wanted to reclaim, to the end of the > inactive list. That way the VM will find those pages first > next time it needs to free memory. > This patch apply the rule in memcg. > It can help to prevent unnecessary working page eviction of memcg. > > Acked-by: Balbir Singh > Acked-by: KAMEZAWA Hiroyuki > Reviewed-by: Rik van Riel > Cc: KOSAKI Motohiro > Cc: Johannes Weiner > Signed-off-by: Minchan Kim > --- Hmm... "inline inline" is an error on some gcc versions CC arch/x86/kernel/asm-offsets.s In file included from include/linux/swap.h:8, from include/linux/suspend.h:4, from arch/x86/kernel/asm-offsets.c:12: include/linux/memcontrol.h:220: error: duplicate `inline' make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > +static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page) > +{ > + return ; > +} > + [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page proto commit 3f58a8294333 (move memcg reclaimable page into tail of inactive list) added inline keyword twice in its prototype. Signed-off-by: Eric Dumazet Cc: Minchan Kim Cc: Andrew Morton Cc: Balbir Singh Cc: KAMEZAWA Hiroyuki Cc: KOSAKI Motohiro Cc: Johannes Weiner --- diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 5a5ce70..5e9840f5 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -216,7 +216,7 @@ static inline void mem_cgroup_del_lru_list(struct page *page, int lru) return ; } -static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page) +static inline void mem_cgroup_rotate_reclaimable_page(struct page *page) { return ; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/