Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754232Ab1C1NqF (ORCPT ); Mon, 28 Mar 2011 09:46:05 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:36961 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754085Ab1C1NqD (ORCPT ); Mon, 28 Mar 2011 09:46:03 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=QSZYkKKUuuGG1XlPvyc0Jy8zB7R/1/d6sNfkateh+z4zg+zdoQlDDuDuZDL1uit7rv jAdgTyL0nTNpIPpEv6BuMDsoMduhe9qSOyqd9Rwmh8XojsUmmQ1O50jWsB0NNtPu8NFW polbqNGckgaAESEQrHpnpeqIQ/xGellEZSHxs= Date: Mon, 28 Mar 2011 22:45:40 +0900 From: Minchan Kim To: Eric Dumazet Cc: Andrew Morton , Johannes Weiner , linux-mm , LKML , Steven Barrett , Ben Gamari , Peter Zijlstra , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Wu Fengguang , Nick Piggin , Andrea Arcangeli , Balbir Singh , KAMEZAWA Hiroyuki Subject: Re: [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page Message-ID: <20110328134540.GD1892@barrios-desktop> References: <20110221084014.GC25382@cmpxchg.org> <20110221155925.GA5641@barrios-desktop> <1301316706.3182.27.camel@edumazet-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1301316706.3182.27.camel@edumazet-laptop> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2474 Lines: 61 On Mon, Mar 28, 2011 at 02:51:46PM +0200, Eric Dumazet wrote: > Le mardi 22 f?vrier 2011 ? 00:59 +0900, Minchan Kim a ?crit : > > Fixed version. > > > > From be7d31f6e539bbad1ebedf52c6a51a4a80f7976a Mon Sep 17 00:00:00 2001 > > From: Minchan Kim > > Date: Tue, 22 Feb 2011 00:53:05 +0900 > > Subject: [PATCH v7 2/3] memcg: move memcg reclaimable page into tail of inactive list > > > > The rotate_reclaimable_page function moves just written out > > pages, which the VM wanted to reclaim, to the end of the > > inactive list. That way the VM will find those pages first > > next time it needs to free memory. > > This patch apply the rule in memcg. > > It can help to prevent unnecessary working page eviction of memcg. > > > > Acked-by: Balbir Singh > > Acked-by: KAMEZAWA Hiroyuki > > Reviewed-by: Rik van Riel > > Cc: KOSAKI Motohiro > > Cc: Johannes Weiner > > Signed-off-by: Minchan Kim > > --- > > Hmm... "inline inline" is an error on some gcc versions > > CC arch/x86/kernel/asm-offsets.s > In file included from include/linux/swap.h:8, > from include/linux/suspend.h:4, > from arch/x86/kernel/asm-offsets.c:12: > include/linux/memcontrol.h:220: error: duplicate `inline' > make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > > > > +static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page) > > +{ > > + return ; > > +} > > + > > [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page proto > > commit 3f58a8294333 (move memcg reclaimable page into tail of inactive > list) added inline keyword twice in its prototype. > > Signed-off-by: Eric Dumazet > Cc: Minchan Kim > Cc: Andrew Morton > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki > Cc: KOSAKI Motohiro > Cc: Johannes Weiner Reviewed-by: Minchan Kim It a was totally my fault. Thanks very much. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/