Date: Mon, 28 Mar 2011 17:18:49 +0100
From: Alan Cox <alan@linux.intel.com>
To: Lu Guanqun <guanqun.lu@intel.com>
Cc: meego-kernel@lists.meego.com, arjan@linux.intel.com,
        fengguang.wu@intel.com, feng.tang@intel.com, michael.fu@intel.com,
        xingchao.wang@intel.com, vinod.koul@intel.com, jeeja.kp@intel.com,
        Jeff Cheng <jeff_cheng@wistron.com>,
        Greg Kroah-Hartman <gregkh@suse.de>,
        Ramesh Babu K V <ramesh.babu@intel.com>,
        Dharageswari R <dharageswari.r@intel.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line
Message-ID: <20110328171849.76243726@bob.linux.org.uk>
In-Reply-To: <1301279360-9839-3-git-send-email-guanqun.lu@intel.com>
References: <1301279360-9839-1-git-send-email-guanqun.lu@intel.com>
	<1301279360-9839-3-git-send-email-guanqun.lu@intel.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 24

On Mon, 28 Mar 2011 10:29:20 +0800
Lu Guanqun <guanqun.lu@intel.com> wrote:

> This patch originates from Jeff Cheng's patch to enable the internal
> speaker.
> 
> On Moorestown platform, internal speaker's power line is connected to
> a GPIO line, this information is got from SFI GPIO table, so we need
> set it to 1 to enable the internal speaker, or set it to 0 to disable
> it.
> 
> When we set the output device, we power on or off the internal
> speaker on demand.

This one looks fine to me - just need to figure out the right way to
get the GPIO pin. Really for a PCI device it ought to be coming from
the PCI space. I will talk to Arjan and co about it.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/