Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812Ab1C2Axe (ORCPT ); Mon, 28 Mar 2011 20:53:34 -0400 Received: from mga11.intel.com ([192.55.52.93]:53647 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257Ab1C2Axd (ORCPT ); Mon, 28 Mar 2011 20:53:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.63,258,1299484800"; d="scan'208";a="902869301" Subject: Re: [PATCH]mmap: not merge cloned VMA From: Shaohua Li To: Andi Kleen Cc: Andrew Morton , linux-mm , lkml , Rik van Riel , Hugh Dickins In-Reply-To: References: <1301277534.3981.26.camel@sli10-conroe> Content-Type: text/plain; charset="UTF-8" Date: Tue, 29 Mar 2011 08:53:31 +0800 Message-ID: <1301360011.3981.30.camel@sli10-conroe> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3741 Lines: 95 On Tue, 2011-03-29 at 00:57 +0800, Andi Kleen wrote: > Shaohua Li writes: > > > Avoid merging a VMA with another VMA which is cloned from parent process. The > > cloned VMA shares lock with parent process's VMA. If we do the merge, more vma > > area (even the new range is only for current process) uses perent process's > > anon_vma lock, so introduces scalability issues. > > find_mergeable_anon_vma already considers this. > In theory this could prevent quite some VMA merging, but I guess the > tradeoff is worth it and that should be unlikely to hit anyways. I'd expect there aren't too many VMAs cloned from parents. > > static inline int is_mergeable_anon_vma(struct anon_vma *anon_vma1, > > - struct anon_vma *anon_vma2) > > + struct anon_vma *anon_vma2, > > + struct vm_area_struct *vma) > > { > > - return !anon_vma1 || !anon_vma2 || (anon_vma1 == anon_vma2); > > + if ((!anon_vma1 || !anon_vma2) && (!vma || > > + list_is_singular(&vma->anon_vma_chain))) > > + return 1; > > I think this if () needs a comment. ok, updated the patch. Avoid merging a VMA with another VMA which is cloned from parent process. The cloned VMA shares lock with parent process's VMA. If we do the merge, more vma area (even the new range is only for current process) uses perent process's anon_vma lock, so introduces scalability issues. find_mergeable_anon_vma already considers this. Signed-off-by: Shaohua Li --- mm/mmap.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) Index: linux/mm/mmap.c =================================================================== --- linux.orig/mm/mmap.c 2011-03-29 08:22:01.000000000 +0800 +++ linux/mm/mmap.c 2011-03-29 08:30:12.000000000 +0800 @@ -699,9 +699,17 @@ static inline int is_mergeable_vma(struc } static inline int is_mergeable_anon_vma(struct anon_vma *anon_vma1, - struct anon_vma *anon_vma2) + struct anon_vma *anon_vma2, + struct vm_area_struct *vma) { - return !anon_vma1 || !anon_vma2 || (anon_vma1 == anon_vma2); + /* + * The list_is_singular() test is to avoid merging VMA cloned from + * parents. This can improve scalability caused by anon_vma lock. + */ + if ((!anon_vma1 || !anon_vma2) && (!vma || + list_is_singular(&vma->anon_vma_chain))) + return 1; + return anon_vma1 == anon_vma2; } /* @@ -720,7 +728,7 @@ can_vma_merge_before(struct vm_area_stru struct anon_vma *anon_vma, struct file *file, pgoff_t vm_pgoff) { if (is_mergeable_vma(vma, file, vm_flags) && - is_mergeable_anon_vma(anon_vma, vma->anon_vma)) { + is_mergeable_anon_vma(anon_vma, vma->anon_vma, vma)) { if (vma->vm_pgoff == vm_pgoff) return 1; } @@ -739,7 +747,7 @@ can_vma_merge_after(struct vm_area_struc struct anon_vma *anon_vma, struct file *file, pgoff_t vm_pgoff) { if (is_mergeable_vma(vma, file, vm_flags) && - is_mergeable_anon_vma(anon_vma, vma->anon_vma)) { + is_mergeable_anon_vma(anon_vma, vma->anon_vma, vma)) { pgoff_t vm_pglen; vm_pglen = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; if (vma->vm_pgoff + vm_pglen == vm_pgoff) @@ -817,7 +825,7 @@ struct vm_area_struct *vma_merge(struct can_vma_merge_before(next, vm_flags, anon_vma, file, pgoff+pglen) && is_mergeable_anon_vma(prev->anon_vma, - next->anon_vma)) { + next->anon_vma, NULL)) { /* cases 1, 6 */ err = vma_adjust(prev, prev->vm_start, next->vm_end, prev->vm_pgoff, NULL); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/