Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529Ab1C2NWV (ORCPT ); Tue, 29 Mar 2011 09:22:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59793 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061Ab1C2NWU (ORCPT ); Tue, 29 Mar 2011 09:22:20 -0400 Date: Tue, 29 Mar 2011 09:22:16 -0400 From: Aristeu Rozanski To: Steven Hardy Cc: Greg KH , mjg@redhat.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PATCH 2/3 (2nd draft)] Resend : Fix memory leak in qcserial driver Message-ID: <20110329132216.GS2526@redhat.com> References: <1301321186.4397.13.camel@shardy.csb> <20110328142148.GA19521@suse.de> <20110328221636.GA8195@shardy.csb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110328221636.GA8195@shardy.csb> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 541 Lines: 18 On Mon, Mar 28, 2011 at 11:16:37PM +0100, Steven Hardy wrote: > + /* Set serial->private if not returning -ENODEV */ > + if ( retval != -ENODEV ) ^ ^ coding style > + usb_set_serial_data(serial, data); > return retval; > } the rest looks good to me. -- Aristeu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/